Merged
Conversation
When a resource management task exited with the None message, previously this did not cause the task's revoke token to be taken out of the list of oustanding tasks. This can cause problems later if a failover is needed on that host. The host task can trigger the revoke token, but since the task already exited, that signal will get lost. Then, the revoke token will never get taken out of the outstanding tasks bucket, and the host task will wait forever instead of proceeding with fencing. This fixes the bug by making the host task remove the revoke token in the HostMessage::None case. Doing so requires that the None message store the resource group ID so that the host task knows which resource group to remove from the bucket. Add a test for this case.
Also adds a TlsConnector object to the Cluster object so that the connector doesn't need to be created anew every time a new connection is initiated to the remote daemon.
They were significantly broken. They had no awareness of failover, and also did not communicate with the manager process so could do actions that contradict what the manager might be trying to do. If their functionality is still desired, they will need to be re-implemented as programs that communicate via the manager to perform their actions. They will also need failover awareness.
bertschinger
force-pushed
the
more_bugfixes
branch
from
adafeb9 to
225da0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.