feat!: introduce more field input types to HumanInputNode#55
Merged
WH-2099 merged 34 commits intoMay 13, 2026
Conversation
The following input field types are added: - `SELECT`: for single select fields - `FILE`: for file field that accepts a single file - `FILE_LIST`: for file input fields that accepts zero or more files.
|
All contributors on this pull request have signed the CLA. |
Change the `FormInput` to `ParagraphInput` to clarify that this is only the input defition for `PRRAGRAPH` input field type. Rename `FormInputDefault` to `StringSource` to indicate that this is the source configuration for a string field in form. BREAKING CHANGE: `FormInput` and `FormInputDefault` renamed
Since this field is used both for form default values and select option sources, `PlaceholderType` is not a accurate name for it. BREAKING CHANGE: PlaceholderType renamed.
The frontend code only utilizes the `PARAGRAPH` input type now. Drop `TEXT_INPUT` to avoid extra maintenance burden. BREAKING CHANGE: `FormInputType.TEXT_INPUT` removed
QuantumGhost
force-pushed
the
QuantumGhost/hitl-form-dsl
branch
from
e0685a4 to
88a8e91
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
The following new input field types are added: - select - file - file-list
Use PLC1901 in tests making tests more obscure. For example, it is clear that the following code assert x should be an empty string. ```py assert x == "" ``` However, `PLC1901` prohibits comparison to empty string and advocates the following code: ```py assert not x ``` The later is less clear as we cannot see what's the property tests are asserting from a glimpse. Instead, we must taking the type of `x` into account while reading test code. It makes reading tests harder. Documentation Link: https://docs.astral.sh/ruff/rules/compare-to-empty-string/
QuantumGhost
force-pushed
the
QuantumGhost/hitl-form-dsl
branch
from
88a8e91 to
f445e74
Compare
dosubot
Bot
added
size:L
QuantumGhost
changed the title
laipz8200
reviewed
Apr 20, 2026
- add `Config` suffix to `BaseInput` and its subclasses, `UserAction` and `FormInput` to indicate this is only the configuration for those types - fix typing issues with `BaseInput`
…ods and properties
…ods and properties
…ods and properties
…untimeProtocol This method does not need alternative impmentations and should not belong to the interface.
dosubot
Bot
added
size:XL
Rename _InvalidSubmittedDataError to InvalidSubmittedDataError
WH-2099
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: rename multiple existing classes and remove unused enumeration members
Related Issue
Closes #54
Summary
SELECTFILEFILE_LISTFormInputtoParagraphInputFormInputDefaulttoStringSourceFormInputType.TEXT_INPUTenumeration memberVariablePool.get_all_by_nodemethod.editorconfigfilePLC1901in test files, since I believe it makes assertions more obscureReadOnlyVariablePoolimplementationsChecklist
!