Skip to content

docs: clarify propagate_attributes scope, trace.list lightweight views, and ingestion lag#3316

Open
jannikmaierhoefer wants to merge 1 commit into
mainfrom
docs/propagation-scope-list-vs-get-ingestion-lag
Open

docs: clarify propagate_attributes scope, trace.list lightweight views, and ingestion lag#3316
jannikmaierhoefer wants to merge 1 commit into
mainfrom
docs/propagation-scope-list-vs-get-ingestion-lag

docs: clarify propagate_attributes scope, trace.list lightweight view…

3fd5857
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Jul 16, 2026 in 11m 55s

Code review found 1 important issue

Found 5 candidates, confirmed 3. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 2
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important content/docs/observability/features/sessions.mdx:194-198 Claim that observations never expose userId/sessionId contradicts documented v2 Observations API
🟡 Nit content/docs/api-and-data-platform/features/query-via-sdk.mdx:75-79 trace.list lightweight-view docs added only to Python tab, missing from JS/TS tab
🟡 Nit content/docs/observability/features/sessions.mdx:191-198 Duplicated 'Scope and ordering' propagation text across 3 pages

Annotations

Check failure on line 198 in content/docs/observability/features/sessions.mdx

See this annotation in the file changed.

@claude claude / Claude Code Review

Claim that observations never expose userId/sessionId contradicts documented v2 Observations API

The new callouts in sessions.mdx, users.mdx, and instrumentation.mdx claim observation objects from "the public API" never expose `sessionId`/`userId`, but this contradicts `observations-api.mdx`: the v2 Observations API's `basic` field group — returned by default and requested by the `observations.get_many(..., fields="core,basic,usage")` call recommended one paragraph above — explicitly returns `userId` and `sessionId` per observation (its sample response shows `"sessionId": "support-chat-sess

Check warning on line 79 in content/docs/api-and-data-platform/features/query-via-sdk.mdx

See this annotation in the file changed.

@claude claude / Claude Code Review

trace.list lightweight-view docs added only to Python tab, missing from JS/TS tab

The new 'Traces: list returns lightweight views' section (documenting that trace.list's observations/scores fields are IDs-only, plus a list-then-get pagination example) was added only to the Python SDK tab in query-via-sdk.mdx; the JS/TS SDK tab jumps straight from Observations to Metrics with no equivalent guidance, even though this is a property of the shared Public API that applies identically to `langfuse.api.trace.list` in `@langfuse/client`. Consider mirroring the section (with a TS list-

Check warning on line 198 in content/docs/observability/features/sessions.mdx

See this annotation in the file changed.

@claude claude / Claude Code Review

Duplicated 'Scope and ordering' propagation text across 3 pages

The new 'Scope and ordering' sections in sessions.mdx and users.mdx are near-verbatim duplicates (only sessionId/userId swapped), and instrumentation.mdx adds a third paragraph restating the same rules — duplicating the exact pattern that PropagationRestrictionsCallout.tsx was built to avoid across these same three pages. Consider consolidating into that shared component (e.g. via a scope/ordering prop) so future corrections to this behavior only need to be made once.