Add changelog docs check gh-aw workflow#3282
Draft
annabellscha wants to merge 11 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@claude review |
Comment on lines
+73
to
+75
|
|
||
| ## Review window | ||
|
|
Contributor
There was a problem hiding this comment.
72-hour window causes repeated Slack alerts
The scheduled cron runs once per day (0 7 * * *), but the review window is set to 72 hours. Any product change that genuinely lacks docs coverage will appear in three consecutive daily Slack messages before it ages out of the window. A window of 25–27 hours captures all changes without meaningful overlap between runs, keeping the channel signal-to-noise ratio high.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/changelog-docs-check.md
Line: 73-75
Comment:
**72-hour window causes repeated Slack alerts**
The scheduled cron runs once per day (`0 7 * * *`), but the review window is set to 72 hours. Any product change that genuinely lacks docs coverage will appear in three consecutive daily Slack messages before it ages out of the window. A window of 25–27 hours captures all changes without meaningful overlap between runs, keeping the channel signal-to-noise ratio high.
How can I resolve this? If you propose a fix, please make it concise.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
annabellscha
marked this pull request as draft
July 10, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLACK_WEBHOOK_URLand appends the Annabell feedback footerTesting
Notes
workflow_dispatchonly appears once the workflow exists on the default branch#lf-team-engineeringGreptile Summary
This PR adds a daily/manual GitHub Agentic Workflow (
gh-aw) that uses Claude Code to scan recent merged PRs and releases inlangfuse/langfuseagainst changelog and docs coverage inlangfuse/langfuse-docs, posting a structured Slack digest via an incoming webhook. It also ships the auto-generated maintenance workflow, compiled lock file, SHA-pinned actions lock, and.gitattributesmarking the lock files as generated artifacts.changelog-docs-check.md+ compiled lock — read-only Claude Code agent, scoped to two langfuse repos viaCROSS_REPO_PAT, firewall-restricted egress, and a single Slack safe-output per run. All actions and container images are digest-pinned.slack-dm-notify.md— safe-output job that posts to a Slack incoming webhook and appends a feedback footer; includes staged-mode preview, correctok-response validation, and duplicate-footer guard.agentics-maintenance.yml— standard gh-aw maintenance workflow for expiring entities, cache cleanup, and manual operations, with per-job fork guards and minimal permission scopes.Confidence Score: 4/5
Safe to merge — the change adds a new read-only automated workflow with no write access to either product repo, all secrets are correctly scoped, and the generated lock file is properly SHA-pinned throughout.
The workflow logic is sound and the security posture is well-considered. The 72-hour lookback window on a daily schedule will produce three consecutive Slack alerts for any uncovered product change, which may become noisy over time. The actions/github-script@v8 pin in the source file is inconsistent with the @v9 used in the rest of the compiled output. Neither issue blocks correctness but both are worth addressing before the workflow generates its first real output.
changelog-docs-check.md for the review window duration, and shared/slack-dm-notify.md for the github-script version.
Sequence Diagram
%%{init: {'theme': 'neutral'}}%% sequenceDiagram participant Cron as Schedule (0 7 * * *) participant Act as activation job participant Ag as agent job participant ClaudeCode as Claude Code CLI participant GH as GitHub MCP (langfuse/langfuse + langfuse-docs) participant SO as safeoutputs MCP participant SlackJob as slack-channel-notify (safe-output) participant Slack as Slack Incoming Webhook Cron->>Act: trigger daily Act->>Act: validate secrets, check lock file, build prompt Act->>Ag: pass activation artifact Ag->>ClaudeCode: run with MCP tools ClaudeCode->>GH: list recent PRs / releases in langfuse/langfuse (72h) GH-->>ClaudeCode: product changes ClaudeCode->>GH: inspect content/changelog/ in langfuse-docs GH-->>ClaudeCode: existing coverage ClaudeCode->>SO: slack_channel_notify(message) SO-->>Ag: write safe output JSONL Ag->>SlackJob: read safeoutputs.jsonl SlackJob->>SlackJob: append Annabell footer SlackJob->>Slack: POST webhook JSON payload Slack-->>SlackJob: "ok"%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%% sequenceDiagram participant Cron as Schedule (0 7 * * *) participant Act as activation job participant Ag as agent job participant ClaudeCode as Claude Code CLI participant GH as GitHub MCP (langfuse/langfuse + langfuse-docs) participant SO as safeoutputs MCP participant SlackJob as slack-channel-notify (safe-output) participant Slack as Slack Incoming Webhook Cron->>Act: trigger daily Act->>Act: validate secrets, check lock file, build prompt Act->>Ag: pass activation artifact Ag->>ClaudeCode: run with MCP tools ClaudeCode->>GH: list recent PRs / releases in langfuse/langfuse (72h) GH-->>ClaudeCode: product changes ClaudeCode->>GH: inspect content/changelog/ in langfuse-docs GH-->>ClaudeCode: existing coverage ClaudeCode->>SO: slack_channel_notify(message) SO-->>Ag: write safe output JSONL Ag->>SlackJob: read safeoutputs.jsonl SlackJob->>SlackJob: append Annabell footer SlackJob->>Slack: POST webhook JSON payload Slack-->>SlackJob: "ok"Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Add temporary push trigger for workflow ..." | Re-trigger Greptile