Skip to content

chore: upgrade Rust toolchain to 1.94.0#6460

Merged
wjones127 merged 3 commits intolance-format:mainfrom
wjones127:chore/upgrade-rust-toolchain-1.94.0
Apr 9, 2026
Merged

chore: upgrade Rust toolchain to 1.94.0#6460
wjones127 merged 3 commits intolance-format:mainfrom
wjones127:chore/upgrade-rust-toolchain-1.94.0

Conversation

@wjones127
Copy link
Copy Markdown
Contributor

Upgrades the pinned Rust toolchain from 1.91.0 to 1.94.0.

The only code change needed was boxing two futures in build_partial_fixture in the distributed_vector_build bench, where 1.94's stricter layout computation overflowed the default recursion limit. Boxing makes the awaited futures' sizes constant (a pointer), breaking the recursion.

Box futures in `build_partial_fixture` to avoid query depth overflow
introduced by stricter layout computation in 1.94.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the chore label Apr 8, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Rust 1.94 lints `#[macro_export]` macros imported via `use` within their
own crate, since they are already in scope automatically.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the java label Apr 9, 2026
@wjones127 wjones127 marked this pull request as ready for review April 9, 2026 21:20
@wjones127 wjones127 merged commit f2db129 into lance-format:main Apr 9, 2026
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants