Fixing the Python binding of vpColor - #2001
Merged
Merged
Conversation
…sp.core.Color The problem comes from the fact that vpColor had a virtual destructor and not vpRGBa. Due to that, vpColor had a vtable but not vpRGBa, which led to a wrong memory access by Pybind11
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
- Coverage 47.61% 47.58% -0.03%
==========================================
Files 532 532
Lines 69468 69465 -3
Branches 32422 32393 -29
==========================================
- Hits 33074 33053 -21
+ Misses 32318 32316 -2
- Partials 4076 4096 +20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FIX] Fixing issue #2000 reporting inconsistent behavior of visp.coreColor
The problem comes from the fact that vpColor had a virtual destructor and not vpRGBa. Due to that, vpColor had a vtable but not vpRGBa, which led to a wrong memory access by Pybind11