Skip to content

fix: ensures the number of ports preserves after loading the project #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexander-Zyurkalov wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ensures the number of ports preserves after loading the project #1101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 25 additions & 8 deletions src/engine/graphmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,21 @@ class GraphManager::Binding
{
auto sub = dynamic_cast<GraphNode*> (object.get());
jassert (sub);

for (auto portType : { PortType::Audio, PortType::Midi })
{
PortArray savedIns, savedOuts;
node.getPorts (savedIns, savedOuts, portType);
if (savedIns.size() != sub->getNumPorts (portType, true))
{
sub->setNumPorts (portType, savedIns.size(), true, false);
}
if (savedOuts.size() != sub->getNumPorts (portType, false))
{
sub->setNumPorts (portType, savedOuts.size(), false, false);
}
}

manager = std::make_unique<GraphManager> (*sub, owner.pluginManager);
manager->setNodeModel (node);
IONodeEnforcer addIO (*manager);
Expand Down Expand Up @@ -768,13 +783,21 @@ void GraphManager::setupNode (const ValueTree& data, ProcessorPtr obj)
jassert (obj && data.hasType (types::Node));
Node node (data, false);
node.setProperty (tags::type, obj->getTypeString())
.setProperty (tags::object, obj.get())
.setProperty (tags::updater, new NodeModelUpdater (*this, data, obj.get()));
.setProperty (tags::object, obj.get());

PortArray ins, outs;
node.getPorts (ins, outs, PortType::Audio);
bool resetPorts = false;
juce::ignoreUnused (resetPorts);

if (obj->isSubGraph())
{
bindings.add (new Binding (*this, obj, node));
resetPorts = true;
}

node.setProperty (tags::updater, new NodeModelUpdater (*this, data, obj.get()));

if (auto* const proc = obj->getAudioProcessor())
{
bool busesConfigured = false;
Expand Down Expand Up @@ -831,12 +854,6 @@ void GraphManager::setupNode (const ValueTree& data, ProcessorPtr obj)
}
}

if (obj->isSubGraph())
{
bindings.add (new Binding (*this, obj, node));
resetPorts = true;
}

node.restorePluginState();
node.resetPorts();
if (node.isA ("Element", EL_NODE_ID_MIDI_INPUT_DEVICE) || node.isA ("Element", EL_NODE_ID_MIDI_OUTPUT_DEVICE))
Expand Down
Loading