feat(bin): scope outward-facing published text to the repository under change - #2469
Closed
TheKingJulian wants to merge 3 commits into
Closed
Conversation
Run intent is composed from a worker's working context and published verbatim as the PR description. Nothing filtered identifiers belonging to another repository, a private task, or the local machine, so a private task name, two foreign commit ids, and a gate-clone id reached a public PR body and stayed readable after the PR was closed, because a closed PR keeps its body. The same class also reached tracked verification prose. Establish the contract: an identifier may appear in outward-facing text only when a reader holding the repository under change, and nothing else, could resolve it. This is a scoping rule and never a length rule - the accepted requirements are exactly what a PR description is for. - bin/fm-outward-text-check.sh reports foreign object ids, forge URLs naming another repository, machine-local paths, and other tasks' or projects' private names. Every verdict is decided against the repository under change rather than by keyword heuristics, so prose about dates, versions, commands, and relative paths is never matched. - Generated no-mistakes and direct-PR briefs require the worker to check the intent or PR body before publishing. That is the only point that can act before a description exists, since posting cannot be undone. - Repo invariants CI scans prose the branch adds and fails on blocking findings. Blocking covers what nothing outside one machine or one fleet can ever resolve; an unresolvable id stays reviewable because a named upstream can make it legitimate, and .fm-outward-allow settles those once. - Replace a real captain home path recorded in Herdr injection evidence with a placeholder, which the check found in the existing tracked docs. docs/outward-facing-text.md owns the contract; the script header owns the options, categories, and known bounds.
…g blocking findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn by the author. Opened against the upstream project in error; this work belongs on the author's fork.