fix: use sequential api key nonces#94
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
4 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/keygen/key-generator.tsx">
<violation number="1" location="src/features/keygen/key-generator.tsx:410">
P3: Restore the correct ESLint rule name; otherwise the dependency warning is no longer suppressed.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| // We intentionally react to connection/chain/signing state transitions. | ||
| // Handler identities are recreated on render and are not used as effect triggers. | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| // eslint-disable-next-line react/exhaustive-deps |
There was a problem hiding this comment.
P3: Restore the correct ESLint rule name; otherwise the dependency warning is no longer suppressed.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/features/keygen/key-generator.tsx, line 410:
<comment>Restore the correct ESLint rule name; otherwise the dependency warning is no longer suppressed.</comment>
<file context>
@@ -411,7 +407,7 @@ export function KeyGenerator() {
// We intentionally react to connection/chain/signing state transitions.
// Handler identities are recreated on render and are not used as effect triggers.
- // eslint-disable-next-line react-hooks/exhaustive-deps
+ // eslint-disable-next-line react/exhaustive-deps
}, [
autoProceedAfterConnect,
</file context>
Suggested change
| // eslint-disable-next-line react/exhaustive-deps | |
| // eslint-disable-next-line react-hooks/exhaustive-deps |
986387c to
cf07a3f
Compare
Contributor
Author
|
@ibruno I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/features/keygen/key-generator.tsx">
<violation number="1" location="src/features/keygen/key-generator.tsx:410">
P3: Restore the correct ESLint rule name; otherwise the dependency warning is no longer suppressed.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Switches API key generation to sequential nonces derived from existing key metadata across Kuest services. Removes manual nonce input, prevents mismatches and duplicate signing, and makes key creation reliable across services.
Bug Fixes
/auth/derive-api-keyto avoid duplicate errors.New Features
listKuestKeyMetadataandnextKuestNonceFromMetadata;listKuestKeysnow returns only active keys.Written for commit f5c0ac2. Summary will update on new commits. Review in cubic