Add Metis glibc floor test Prow job#36769
Conversation
|
Welcome @arvindbr8! |
|
Hi @arvindbr8. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@gnossen: changing LGTM is restricted to collaborators DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml
Outdated
Show resolved
Hide resolved
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arvindbr8, gnossen, YifeiZhuang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@arvindbr8: Updated the
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR adds a new Prow presubmit job
pull-cloud-provider-gcp-metis-glibc-floor-testfor thekubernetes/cloud-provider-gcprepository.This job is designed to run a GLIBC floor compatibility test for the
metiscomponent to ensure that the CGO binary built in Metis does not violate link constraints against GLIBC 2.35.Details:
^metis/.cd metis && make test-glibc-floor.gcr.io/k8s-staging-test-infra/kubekins-e2e:v20260316-e86cefa561-master.This test job consumes the new Makefile target added in the corresponding PR in
cloud-provider-gcp:Special notes for your reviewer:
The job was added to
config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml. To pass the repository's configuration tests, I added the required TestGrid annotations and explicitly assigned it to thek8s-infra-prow-buildcluster.Verification done:
Ran
go test ./config/tests/...locally and all tests passed successfully after addressing deprecations and missing annotations.PTAL: @gnossen @YifeiZhuang