Skip to content

Add Metis glibc floor test Prow job#36769

Merged
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
arvindbr8:add-metis-glibc-floor-test
Apr 6, 2026
Merged

Add Metis glibc floor test Prow job#36769
k8s-ci-robot merged 3 commits intokubernetes:masterfrom
arvindbr8:add-metis-glibc-floor-test

Conversation

@arvindbr8
Copy link
Copy Markdown
Contributor

@arvindbr8 arvindbr8 commented Apr 6, 2026

What this PR does / why we need it:
This PR adds a new Prow presubmit job pull-cloud-provider-gcp-metis-glibc-floor-test for the kubernetes/cloud-provider-gcp repository.

This job is designed to run a GLIBC floor compatibility test for the metis component to ensure that the CGO binary built in Metis does not violate link constraints against GLIBC 2.35.

Details:

  • Trigger: Runs on changes matching ^metis/.
  • Command: cd metis && make test-glibc-floor.
  • Image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20260316-e86cefa561-master.
  • Requirements: Requires Docker-in-Docker and privileged security context.

This test job consumes the new Makefile target added in the corresponding PR in cloud-provider-gcp:

Special notes for your reviewer:
The job was added to config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml. To pass the repository's configuration tests, I added the required TestGrid annotations and explicitly assigned it to the k8s-infra-prow-build cluster.

Verification done:
Ran go test ./config/tests/... locally and all tests passed successfully after addressing deprecations and missing annotations.

PTAL: @gnossen @YifeiZhuang

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Apr 6, 2026
@k8s-ci-robot k8s-ci-robot added area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Apr 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Welcome @arvindbr8!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @arvindbr8. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@gnossen: changing LGTM is restricted to collaborators

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@YifeiZhuang
Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2026
@YifeiZhuang
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arvindbr8, gnossen, YifeiZhuang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026
@k8s-ci-robot k8s-ci-robot merged commit eba17f2 into kubernetes:master Apr 6, 2026
6 checks passed
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

@arvindbr8: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cloud-provider-gcp-presubmits.yaml using file config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml
Details

In response to this:

What this PR does / why we need it:
This PR adds a new Prow presubmit job pull-cloud-provider-gcp-metis-glibc-floor-test for the kubernetes/cloud-provider-gcp repository.

This job is designed to run a GLIBC floor compatibility test for the metis component to ensure that the CGO binary built in Metis does not violate link constraints against GLIBC 2.35.

Details:

  • Trigger: Runs on changes matching ^metis/.
  • Command: cd metis && make test-glibc-floor.
  • Image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20260316-e86cefa561-master.
  • Requirements: Requires Docker-in-Docker and privileged security context.

This test job consumes the new Makefile target added in the corresponding PR in cloud-provider-gcp:

Special notes for your reviewer:
The job was added to config/jobs/kubernetes/cloud-provider-gcp/cloud-provider-gcp-presubmits.yaml. To pass the repository's configuration tests, I added the required TestGrid annotations and explicitly assigned it to the k8s-infra-prow-build cluster.

Verification done:
Ran go test ./config/tests/... locally and all tests passed successfully after addressing deprecations and missing annotations.

PTAL: @gnossen @YifeiZhuang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants