Skip to content

fix: capture higher-precision metrics for pod_startup_latency#3891

Open
justinsb wants to merge 1 commit intokubernetes:masterfrom
justinsb:millisecond_metrics
Open

fix: capture higher-precision metrics for pod_startup_latency#3891
justinsb wants to merge 1 commit intokubernetes:masterfrom
justinsb:millisecond_metrics

Conversation

@justinsb
Copy link
Copy Markdown
Member

@justinsb justinsb commented Mar 14, 2026 •
edited
Loading

Issue #3889

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 14, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinsb
Once this PR has been reviewed and has the lgtm label, please assign mborsz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from mborsz and wojtek-t March 14, 2026 17:49
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2026
justinsb
justinsb commented Mar 14, 2026
View reviewed changes
clusterloader2/pkg/measurement/common/slos/pod_startup_latency.go
From: createPhase,
To: schedulePhase,
},
"create_to_schedule_precise": {
Copy link
Copy Markdown
Member Author

@justinsb justinsb Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether we want to just replace the existing metrics or create new ones....

Copy link
Copy Markdown
Contributor

@Qqkyu Qqkyu Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I saw there was leaning towards replacing the existing metric, so let's do that and we'll merge this PR. I'll monitor the tests and revert if anything breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mborsz mborsz Awaiting requested review from mborsz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

1 more reviewer

@Qqkyu Qqkyu Qqkyu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinsb @k8s-ci-robot @Qqkyu