Fix Framework.{Patch,Delete,Get}Object methods not passing APICallOptions to the underlying client methods#3576
Conversation
…Options` to the underlying client methods
|
Hi @yanghanlin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yanghanlin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
/remove-lifecycle stale |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
What type of PR is this?
/kind bug
What this PR does / why we need it:
In
k8s.io/clusterloader2/pkg/framework.(*Framework).{Patch,Delete,Get}Object, the finaloptionsparameter seems to be intended to be forwarded to the underlying client methods to control retry behavior (as inCreateObject). It wasn’t, and in a subsequent cleanup it was renamed to_(dfe847f). This PR plumbs options through to the client calls, restoring the expected configurable retry semantics.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A