Shorten AWS cluster names in kubetest2-kops#18160
Open
rifelpet wants to merge 1 commit intokubernetes:masterfrom
Open
Shorten AWS cluster names in kubetest2-kops#18160rifelpet wants to merge 1 commit intokubernetes:masterfrom
rifelpet wants to merge 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
the
size/S
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
hakman
reviewed
Apr 4, 2026
| jobName = jobName[:gcpLimit] | ||
| } | ||
|
|
||
| // AWS launch template names have a 128-char limit. The longest |
Member
There was a problem hiding this comment.
I don't think it's the right way to do it, ideally we would have added something to trim those names.
It is not a good approach for GCP either...
Member
Author
There was a problem hiding this comment.
are you thinking this should happen in build_jobs.py instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some presubmit job names are so long that the resulting cluster names aren't accepted. This shortens kubetest2-kops' generated cluster names.
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kops/18152/pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons/2039944759954378752
W0403 06:13:56.677631 58468 executor.go:141] error running task "LaunchTemplate/master-ap-southeast-2b.masters.e2e-pr18152.pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons.tests-kops-aws.k8s.io" (3m39s remaining to succeed): operation error EC2: DescribeLaunchTemplateVersions, https response error StatusCode: 400, RequestID: 38269238-47fb-425d-92c5-d8d1e9f9098b, api error InvalidLaunchTemplateName.MalformedException: A launch template name must be between 3 and 128 characters, and may contain letters, numbers, and the following characters: - ( ) . / _.Error: error running tasks: deadline exceeded executing task SQS/e2e-pr18152-pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons-tests-kops-aws-k8s-io-nth. Example error: error creating SQS queue: operation error SQS: CreateQueue, https response error StatusCode: 400, RequestID: 6979b7ae-7ccd-556f-8022-d5e7202c1849, api error InvalidParameterValue: Can only include alphanumeric characters, hyphens, or underscores. 1 to 80 in length