Skip to content

vfs: Pass S3 provider-specific options to clients#18132

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:s3-checksum
Apr 15, 2026
Merged

vfs: Pass S3 provider-specific options to clients#18132
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
hakman:s3-checksum

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Mar 29, 2026

This is mostly a refactoring proposal. WDYT?

/cc @rifelpet @moshevayner

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Mar 30, 2026

/test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

@kubernetes kubernetes deleted a comment from k8s-ci-robot Mar 30, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Mar 30, 2026

/test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

@moshevayner
Copy link
Copy Markdown
Member

moshevayner commented Mar 30, 2026

I really like that approach! Would definitely add needed flexibility for future providers that use S3 with different option sets

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2026
@rifelpet
Copy link
Copy Markdown
Member

rifelpet commented Apr 15, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026 •
edited
Loading

@hakman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons a60550e link false /test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Copy Markdown
Member Author

hakman commented Apr 15, 2026

/override pull-kops-e2e-k8s-aws-amazonvpc
/override pull-kops-e2e-k8s-gce-cilium

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 15, 2026

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-k8s-aws-amazonvpc, pull-kops-e2e-k8s-gce-cilium

Details

In response to this:

/override pull-kops-e2e-k8s-aws-amazonvpc
/override pull-kops-e2e-k8s-gce-cilium

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit b2f9e82 into kubernetes:master Apr 15, 2026
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moshevayner moshevayner Awaiting requested review from moshevayner

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@rifelpet rifelpet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

4 participants

@hakman @moshevayner @rifelpet @k8s-ci-robot