Skip to content

vfs: Pass S3 provider-specific options to clients#18132

Open
hakman wants to merge 1 commit intokubernetes:masterfrom
hakman:s3-checksum
Open

vfs: Pass S3 provider-specific options to clients#18132
hakman wants to merge 1 commit intokubernetes:masterfrom
hakman:s3-checksum

Conversation

@hakman
Copy link
Copy Markdown
Member

@hakman hakman commented Mar 29, 2026

This is mostly a refactoring proposal. WDYT?

/cc @rifelpet @moshevayner

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 29, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Mar 30, 2026

/test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

@kubernetes kubernetes deleted a comment from k8s-ci-robot Mar 30, 2026
@hakman
Copy link
Copy Markdown
Member Author

hakman commented Mar 30, 2026

/test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

@moshevayner
Copy link
Copy Markdown
Member

I really like that approach! Would definitely add needed flexibility for future providers that use S3 with different option sets

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2026
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 2, 2026

@hakman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons a60550e link false /test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants