vfs: Pass S3 provider-specific options to clients#18132
vfs: Pass S3 provider-specific options to clients#18132hakman wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
/test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons |
|
/test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons |
|
I really like that approach! Would definitely add needed flexibility for future providers that use S3 with different option sets |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@hakman: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Ciprian Hacman <[email protected]>
This is mostly a refactoring proposal. WDYT?
/cc @rifelpet @moshevayner