Skip to content

[WIP] Add GCP IP Alias Mode with Cilium CNI#18121

Open
Camila-B wants to merge 5 commits intokubernetes:masterfrom
Camila-B:gcp-with-cilium
Open

[WIP] Add GCP IP Alias Mode with Cilium CNI#18121
Camila-B wants to merge 5 commits intokubernetes:masterfrom
Camila-B:gcp-with-cilium

Conversation

@Camila-B
Copy link
Copy Markdown
Contributor

@Camila-B Camila-B commented Mar 27, 2026

  • Adds the Cilium option inside of GCPNetworkingSpec to allow for Cilium and GCE IP alias

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 27, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 27, 2026

Hi @Camila-B. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Copy Markdown
Member

hakman commented Mar 28, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 28, 2026
@hakman hakman requested review from hakman and justinsb and removed request for johngmyers and olemarkus March 28, 2026 08:05
hakman
hakman reviewed Mar 28, 2026
View reviewed changes
cmd/kops/create_cluster.go
cmd.RegisterFlagCompletionFunc("etcd-storage-type", completeStorageType)

cmd.Flags().StringVar(&options.Networking, "networking", options.Networking, "Networking mode. kubenet, external, flannel-vxlan (or flannel), flannel-udp, calico, kube-router, amazonvpc, cilium, cilium-etcd, kindnet, cni.")
cmd.Flags().StringVar(&options.Networking, "networking", options.Networking, "Networking mode. kubenet, external, flannel-vxlan (or flannel), flannel-udp, calico, kube-router, amazonvpc, cilium, gcp-with-cilium, cilium-etcd, kindnet, cni.")
Copy link
Copy Markdown
Member

@hakman hakman Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Camila-B I think gcp-with-cilium is not exactly describing the option, not is similar to the equivalent AWS option cilium-eni. Would cilium-ipam or cilium-ipam-gcp be a good match?

Copy link
Copy Markdown
Contributor

@rramkumar1 rramkumar1 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hakman What did you mean by this?

"not is similar to the equivalent AWS option cilium-eni"

@Camila-B
Copy link
Copy Markdown
Contributor Author

Camila-B commented Mar 30, 2026

/retest

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Mar 31, 2026

@Camila-B: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons bbd75e7 link false /test pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons d40a898 link false /test pull-kops-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons
pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons d40a898 link false /test pull-kops-aws-upgrade-k134-ko134-to-kstable-kolatest-many-addons
pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons d40a898 link false /test pull-kops-aws-upgrade-k135-ko135-to-kstable-kolatest-many-addons
pull-kops-e2e-cni-kubenet d40a898 link true /test pull-kops-e2e-cni-kubenet
pull-kops-e2e-azure-cni-kubenet d40a898 link true /test pull-kops-e2e-azure-cni-kubenet

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman hakman left review comments

@justinsb justinsb Awaiting requested review from justinsb

+1 more reviewer

@rramkumar1 rramkumar1 rramkumar1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/addons area/api area/documentation area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Camila-B @k8s-ci-robot @hakman @rramkumar1