fix: don't panic when dumping nodes if we didn't capture cloud resources#18072
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Mar 14, 2026
Merged
Conversation
This is a debug path, but avoid panicking if we didn't capture cloud resources, and continue with our fallback path.
k8s-ci-robot
added
the
size/S
k8s-ci-robot
added
the
cncf-cla: yes
Member
Author
|
We observed this in #18068 cc @serathius I think it's because in our bare-metal tests we pass --cloud-resource=false to |
hakman
approved these changes
Mar 14, 2026
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a debug path, but avoid panicking if we didn't capture cloud resources,
and continue with our fallback path.