Skip to content

Add GCS bucket for external TestGrid configurations#9169

Merged
upodroid merged 1 commit intokubernetes:mainfrom
ameukam:testgrid-bucket
Apr 9, 2026
Merged

Add GCS bucket for external TestGrid configurations#9169
upodroid merged 1 commit intokubernetes:mainfrom
ameukam:testgrid-bucket

Conversation

@ameukam
Copy link
Copy Markdown
Member

@ameukam ameukam commented Mar 3, 2026

Add a GCS bucket so we can migrate testgrid dashboards from Google to the Kubernetes infrastructure

Ref:

@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Mar 3, 2026

/hold

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 3, 2026
@k8s-ci-robot k8s-ci-robot requested review from hakman and upodroid March 3, 2026 18:58
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Mar 3, 2026
@k8s-triage-robot
Copy link
Copy Markdown

k8s-triage-robot commented Mar 3, 2026

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla
/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2026
@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Mar 4, 2026

/test pull-k8sio-verify

@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Mar 4, 2026

atlantis plan

@k8s-infra-ci-robot

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/registry.k8s.io Code in registry.k8s.io/ area/release-eng Issues or PRs related to the Release Engineering subproject sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 4, 2026
@k8s-infra-ci-robot
Copy link
Copy Markdown
Contributor

k8s-infra-ci-robot commented Mar 4, 2026 •
edited
Loading

Argo CD Diff Preview

Summary:

No changes found

No changes found

Stats:
[Applications: 76], [Full Run: 1m35s], [Rendering: 1m29s], [Cluster: 0s], [Argo CD: 2s]

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2026
@k8s-infra-ci-robot

This comment has been minimized.

Sign in to view
@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Mar 4, 2026

@upodroid look's like some bindings are not defined in Terraform ?

@upodroid
Copy link
Copy Markdown
Member

upodroid commented Mar 4, 2026

someone merged a broken change to the module

terraform-google-modules/terraform-google-cloud-storage#442

@upodroid upodroid mentioned this pull request Mar 4, 2026
Merged
@BenTheElder BenTheElder mentioned this pull request Mar 9, 2026
Open
@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Mar 9, 2026

@upodroid can we manually actuate this until a fix lands ?

@upodroid
Copy link
Copy Markdown
Member

upodroid commented Mar 9, 2026

Yes. Pin to the previous version

@k8s-infra-ci-robot

This comment has been minimized.

Sign in to view
@k8s-infra-ci-robot

This comment has been minimized.

Sign in to view
@k8s-infra-ci-robot k8s-infra-ci-robot mentioned this pull request Apr 7, 2026
Merged
@xmudrii
Copy link
Copy Markdown
Member

xmudrii commented Apr 7, 2026

atlantis unlock

@k8s-infra-ci-robot

This comment has been minimized.

Sign in to view
@ameukam
Add GCS bucket for external TestGrid configurations
d38bac0 
Add a GCS bucket so we can migrate testgrid dashboards from Google to
the Kubernetes infrastructure

Ref:
  - kubernetes#8973

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@k8s-infra-ci-robot
Copy link
Copy Markdown
Contributor

k8s-infra-ci-robot commented Apr 7, 2026

Ran Plan for dir: infra/gcp/terraform/k8s-infra-prow workspace: default

Plan Failed: This project is currently locked by an unapplied plan from pull #9299. To continue, delete the lock from #9299 or apply that plan and merge the pull request.

Once the lock is released, comment atlantis plan here to re-plan.

@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Apr 7, 2026

cc @BenTheElder @michelle192837
For LGTM

michelle192837
michelle192837 approved these changes Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@michelle192837 michelle192837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Pending the Terraform diff succeeding)

Thanks for adding this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Copy Markdown
Member Author

ameukam commented Apr 7, 2026

Actuation of the resources was done manually. PR can be merged.

BenTheElder
BenTheElder reviewed Apr 7, 2026
View reviewed changes
infra/gcp/terraform/k8s-infra-prow/buckets.tf
source = "terraform-google-modules/cloud-storage/google//modules/simple_bucket"
version = "~> 5"

name = "k8s-testgrid-config-external"
Copy link
Copy Markdown
Member

@BenTheElder BenTheElder Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think it will be harder to get external projects to switch buckets initially than to switch buckets ourselves and eventually phase out the existing bucket, unless I'm missing something?

naming here suggests this bucket would be for other projects?

Copy link
Copy Markdown
Member Author

@ameukam ameukam Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. I just came up with something to not conflict with the current setup. I'm happy to change it for a better suggestion.

@upodroid
Copy link
Copy Markdown
Member

upodroid commented Apr 9, 2026

Merging since the infra exists and Marko needs to pick up the diff

@upodroid upodroid merged commit 3e09d56 into kubernetes:main Apr 9, 2026
2 of 5 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.36 milestone Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hakman hakman Awaiting requested review from hakman

@upodroid upodroid Awaiting requested review from upodroid

2 more reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@michelle192837 michelle192837 michelle192837 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michelle192837 michelle192837

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/prow Setting up or working with prow in general, prow.k8s.io, prow build clusters area/registry.k8s.io Code in registry.k8s.io/ area/release-eng Issues or PRs related to the Release Engineering subproject area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.36

Development

Successfully merging this pull request may close these issues.

8 participants

@ameukam @k8s-triage-robot @k8s-infra-ci-robot @upodroid @xmudrii @k8s-ci-robot @michelle192837 @BenTheElder