Skip to content

Use dedicated cve-feed-maintainers group for CVE feed bucket #9081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pnkcaht wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −5
Open

Use dedicated cve-feed-maintainers group for CVE feed bucket #9081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
515dd67
Use dedicated cve-feed-maintainers group for CVE feed bucket
Pnkcaht Feb 7, 2026
19ec5d7
Revert group change in iam.json and terraform as requested
Pnkcaht Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions audit/projects/kubernetes-public/buckets/k8s-cve-feed/iam.json
View file
Open in desktop
Copy link
Copy Markdown
Member

@xmudrii xmudrii Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think audit files are supposed to be changed manually, but someone from @kubernetes/sig-k8s-infra-leads can correct me if I'm wrong.

Copy link
Copy Markdown
Author

@Pnkcaht Pnkcaht Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I don't judge

Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
{
"members": [
"group:k8s-infra-prow-oncall@kubernetes.io",
"group:security-tooling-private@kubernetes.io"
"group:cve-feed-maintainers@kubernetes.io"
],
"role": "roles/storage.admin"
},
{
"members": [
"group:k8s-infra-prow-oncall@kubernetes.io",
"group:security-tooling-private@kubernetes.io",
"group:cve-feed-maintainers@kubernetes.io",
"projectEditor:kubernetes-public",
"projectOwner:kubernetes-public"
],
Expand All @@ -31,7 +31,7 @@
{
"members": [
"group:k8s-infra-prow-oncall@kubernetes.io",
"group:security-tooling-private@kubernetes.io",
"group:cve-feed-maintainers@kubernetes.io",
"serviceAccount:k8s-cve-feed@k8s-infra-prow-build-trusted.iam.gserviceaccount.com"
],
"role": "roles/storage.objectAdmin"
Expand Down
2 changes: 1 addition & 1 deletion infra/gcp/terraform/kubernetes-public/k8s-cve-feed.tf
View file
Open in desktop
Copy link
Copy Markdown
Member

@xmudrii xmudrii Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to somehow apply this, @upodroid can we use Atlantis for this?

Copy link
Copy Markdown
Author

@Pnkcaht Pnkcaht Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for his response, but in any case, depending on what it is, just let me know and I'll do it right away.

Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ This file defines:
*/

locals {
cve_feed_bucket_owners = "security-tooling-private@kubernetes.io"
cve_feed_bucket_owners = "cve-feed-maintainers@kubernetes.io"
}

// Use a data source for the service account
Expand Down