[occm] Tag security groups with service identifier#3096
[occm] Tag security groups with service identifier#3096dlaw4608 wants to merge 1 commit intokubernetes:masterfrom
Conversation
… enabled
are now tagged with the same format as load balancers and listeners:
kube_service_{cluster}_{namespace}_{name}
Signed-off-by: Daniel Lawton <dlawton@redhat.com>
|
|
Welcome @dlaw4608! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @dlaw4608. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Tags security groups created by OCCM with the same identifier format as load balancers and listeners (
kube_service_{cluster}_{namespace}_{name}).Currently, security groups created when
manage-security-groups: trueare not tagged, making it difficult to identify which cluster owns them in multi-cluster OpenStack environments. This change adds automatic tagging to align with how load balancers and listeners are already tagged.What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: