fix: pin to cloud-controller-manager tag#872
fix: pin to cloud-controller-manager tag#872apeabody wants to merge 4 commits intokubernetes:masterfrom
Conversation
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @apeabody! |
|
Hi @apeabody. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test We'll need to remind people (somehow) to update this tag, but that's a separate topic from this PR IMO /lgtm |
|
I like it! /lgtm |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
/remove-lifecycle rotten |
hdp617
left a comment
There was a problem hiding this comment.
Could you also update the release instruction to bump the CCM image version https://github.com/kubernetes/cloud-provider-gcp/blob/master/docs/RELEASE.md? Thanks!
|
This LGTM. cc @bowei @YifeiZhuang for approval. |
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
/remove-approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apeabody, hdp617 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Validated that v35.0.0 is the newest at registry.k8s.io/cloud-provider-gcp/cloud-controller-manager |
cloud-controller-managerto a current and specific release version:k8scloudprovidergcp/cloud-controller-manager:latest>registry.k8s.io/cloud-provider-gcp/cloud-controller-manager:v35.0.0dependabotto cover manifestsedto use regex instead of hardcoding versionfixes: #754