-
Notifications
You must be signed in to change notification settings - Fork 268
metis: add glibc floor qualification test target to Makefile #1036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arvindbr8
wants to merge
9
commits into
kubernetes:master
Choose a base branch
from
arvindbr8:presubmit-guard-rail
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+45
−7
Open
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a391d44
metis: add glibc floor qualification test and makefile target
arvindbr8 07ff035
update makefile to use GIT_VERSION
arvindbr8 70361a9
metis: refactor glibc floor test per PR review comments
arvindbr8 696d8f2
metis: perfectly generalize glibc version strings in recipe comment
arvindbr8 330e2e7
Merge branch 'master' into presubmit-guard-rail
arvindbr8 deaa1f3
remove ONESHELL
arvindbr8 bfdaad5
remove github actions, moving it to prow
arvindbr8 040f638
fix(metis): sanitize GIT_VERSION to remove prefix for k8s compatibility
arvindbr8 d740249
docs(metis): add warning comment in Dockerfile regarding GLIBC floor
arvindbr8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Metis GLIBC Floor Test | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'metis/**' | ||
|
|
||
| jobs: | ||
| native-execution-test: | ||
| runs-on: ubuntu-22.04 | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Test GLIBC compatibility | ||
| run: | | ||
| cd metis | ||
| make test-glibc-floor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.