chore: remove deprecated rand.Seed usage#1031
chore: remove deprecated rand.Seed usage#1031pujidjayanto wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
|
|
This issue is currently awaiting triage. If the repository mantainers determine this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pujidjayanto The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @pujidjayanto! |
|
Hi @pujidjayanto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Thanks for the PR! Could you sign the CLA? |
signed |
Description
Fixes #1026
Since Go 1.20, the global math/rand source is automatically seeded, making explicit rand.Seed(time.Now().UnixNano()) calls unnecessary. The Go team deprecated rand.Seed in 1.20 and it's a no-op as of the latest versions.
This PR removes the redundant rand.Seed calls and their associated math/rand and time imports from:
I only found the usage on those 2 files (exclude vendor)