tempelis: Add --validate flag for offline config validation

[TineoC]

This PR adds a --validate flag to tempelis for offline config validation. Fixes #65

[k8s-ci-robot]

Welcome @TineoC!

It looks like this is your first PR to kubernetes-sigs/slack-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/slack-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @TineoC. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[BenTheElder]

thanks!

do you think we should do validation beyond config parsing? this seems like a good start anyhow, next we can look at making sure one of the blocking CI presubmits runs this over the project's config

cc @kubernetes-sigs/sig-contributor-experience-leads we should get in touch with the slack admins about this?

[TineoC]

Hi @BenTheElder, thanks for the feedback

I've updated the PR to include a --validate-only flag, which allows for offline configuration validation without requiring Slack credentials. This should fulfill the requirement for running validation in a CI presubmit as you suggested.

Regarding validation beyond parsing: the current parser already enforces schema correctness, detects duplicate channels/users/groups, validates Slack ID formats (9 or 11 characters), and ensures that file-level restrictions are respected. Did you have any other specific offline checks in mind?

[BenTheElder]

Regarding validation beyond parsing: the current parser already enforces schema correctness, detects duplicate channels/users/groups, validates Slack ID formats (9 or 11 characters), and ensures that file-level restrictions are respected. Did you have any other specific offline checks in mind?

TBH It's been forever since I've looked at any of this. Forwarding to the slack-admins + contributor experience ...

/ok-to-test

[Prajyot-Parab]

/cc @Priyankasaggu11929 can you ptal

[k8s-ci-robot]

@Prajyot-Parab: GitHub didn't allow me to request PR reviews from the following users: you, ptal, can.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @Priyankasaggu11929 can you ptal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Priyankasaggu11929]

/lgtm
/approve

PR changes looks good to me, for the purpose of adding a blocking presubmit job.

[Priyankasaggu11929]

@jberkus, could you add your approval here as well. Thanks!

[cpanato]

thanks

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Priyankasaggu11929, TineoC

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment