Skip to content

WIP ✨ (helm/v2-alpha): Add --input-dir flag to helm/v2-alpha plugin to allow operating on projects in different directories#5573

Closed
camilamacedo86 wants to merge 1 commit into
kubernetes-sigs:masterfrom
camilamacedo86:continue-pr-5549
Closed

WIP ✨ (helm/v2-alpha): Add --input-dir flag to helm/v2-alpha plugin to allow operating on projects in different directories#5573
camilamacedo86 wants to merge 1 commit into
kubernetes-sigs:masterfrom
camilamacedo86:continue-pr-5549

Conversation

@camilamacedo86
Copy link
Copy Markdown
Member

@camilamacedo86 camilamacedo86 commented Apr 2, 2026 •
edited
Loading

Closes: #5549

Motivations

Closes: #5548

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 2, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: camilamacedo86 / name: Camila Macedo (612be49)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 2, 2026
@camilamacedo86 camilamacedo86 force-pushed the continue-pr-5549 branch 2 times, most recently from d991c2a to 6b90fda Compare April 2, 2026 06:26
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 2, 2026
@camilamacedo86 camilamacedo86 mentioned this pull request Apr 2, 2026
Draft
@camilamacedo86
Copy link
Copy Markdown
Member Author

camilamacedo86 commented Apr 2, 2026

@porridge @vitorfloriano

WDYT? Could you please review this one?

@camilamacedo86 camilamacedo86 requested a review from Copilot April 5, 2026 04:53
Copilot AI reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an --input-dir flag to the helm/v2-alpha edit subcommand to better support non-standard project layouts (e.g., monorepos) and align UX with other alpha commands by resolving manifests paths relative to a selected project directory.

Changes:

  • Add --input-dir flag to kubebuilder edit --plugins=helm/v2-alpha.
  • Resolve --manifests relative to --input-dir when not absolute; run make in input-dir when generating default manifests.
  • Update docs and a unit test to include the new flag.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
pkg/plugins/optional/helm/v2alpha/edit.go Adds inputDir flag + path resolution and uses it for manifests generation/parsing.
pkg/plugins/optional/helm/v2alpha/edit_test.go Extends BindFlags test to assert the new flag exists.
docs/book/src/plugins/available/helm-v2-alpha.md Documents --input-dir and adds CLI examples.

Comment thread pkg/plugins/optional/helm/v2alpha/edit.go Outdated
Comment thread pkg/plugins/optional/helm/v2alpha/edit.go Outdated
Comment thread pkg/plugins/optional/helm/v2alpha/edit_test.go
Comment thread docs/book/src/plugins/available/helm-v2-alpha.md Outdated
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 5, 2026
@camilamacedo86 camilamacedo86 requested a review from Copilot April 5, 2026 09:44
Copilot AI reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

Comment thread pkg/plugins/optional/helm/v2alpha/edit.go Outdated
Comment thread pkg/plugins/optional/helm/v2alpha/edit.go
Comment thread docs/book/src/plugins/available/helm-v2-alpha.md Outdated
Comment thread pkg/plugins/optional/helm/v2alpha/edit_test.go Outdated
@camilamacedo86 camilamacedo86 force-pushed the continue-pr-5549 branch 2 times, most recently from 0d106a4 to 8fbd052 Compare April 5, 2026 09:55
@camilamacedo86 camilamacedo86 requested a review from Copilot April 5, 2026 09:56
Copilot AI reviewed Apr 5, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread pkg/plugins/optional/helm/v2alpha/edit.go
Comment thread docs/book/src/plugins/available/helm-v2-alpha.md Outdated
@camilamacedo86 camilamacedo86 requested a review from Copilot April 5, 2026 10:46
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2026
@camilamacedo86 camilamacedo86 force-pushed the continue-pr-5549 branch 2 times, most recently from 7b79040 to 5fb5d73 Compare April 11, 2026 06:44
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 11, 2026
@camilamacedo86 camilamacedo86 changed the title WIP ✨ (helm/v2-alpha): add --input-dir flag for flexible project path resolution ✨ (helm/v2-alpha): Add --input-dir flag to helm/v2-alpha plugin to allow operating on projects in different directories Apr 11, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2026
@camilamacedo86 camilamacedo86 requested a review from Copilot April 11, 2026 06:45
Copilot AI reviewed Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Comment thread pkg/cli/edit.go
Comment thread pkg/cli/cli.go Outdated
Comment thread pkg/cli/cli.go Outdated
@camilamacedo86 camilamacedo86 force-pushed the continue-pr-5549 branch 2 times, most recently from 69cbca3 to 4278153 Compare April 11, 2026 07:04
@camilamacedo86 camilamacedo86 requested a review from Copilot April 11, 2026 07:05
Copilot AI reviewed Apr 11, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Comment thread pkg/cli/edit.go
Comment thread pkg/cli/cli.go Outdated
@camilamacedo86 camilamacedo86 requested a review from Copilot April 12, 2026 07:00
Copilot AI reviewed Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Comment thread pkg/cli/cli.go
Comment thread pkg/cli/cli.go Outdated
Comment thread pkg/plugins/optional/helm/v2alpha/edit.go Outdated
Comment thread docs/book/src/plugins/available/helm-v2-alpha.md Outdated
@camilamacedo86 camilamacedo86 requested a review from Copilot April 12, 2026 13:00
@camilamacedo86
chore(helm/v2-aplha): Add --input-dir flag to helm/v2-alpha plugin to…
612be49 
… allow operating on projects in different directories

Generated-by: Claude
Copilot AI reviewed Apr 12, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@camilamacedo86 camilamacedo86 changed the title ✨ (helm/v2-alpha): Add --input-dir flag to helm/v2-alpha plugin to allow operating on projects in different directories WIP ✨ (helm/v2-alpha): Add --input-dir flag to helm/v2-alpha plugin to allow operating on projects in different directories Apr 12, 2026
@camilamacedo86 camilamacedo86 mentioned this pull request Apr 12, 2026
Open
@camilamacedo86
Copy link
Copy Markdown
Member Author

camilamacedo86 commented Apr 15, 2026

We will not able to move with in this way, so I am closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@vitorfloriano vitorfloriano Awaiting requested review from vitorfloriano

@porridge porridge Awaiting requested review from porridge

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. helm/v2-alpha size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a flag for customizing PROJECT file location

4 participants

@camilamacedo86 @k8s-ci-robot @porridge