start using images from registry.k8s.io#4728
start using images from registry.k8s.io#4728upodroid wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/XL
| requests: | ||
| cpu: 10m | ||
| - name: tls-backend | ||
| image: registry.k8s.io/gateway-api/echo-basic:v1.5.1 |
There was a problem hiding this comment.
$ docker pull registry.k8s.io/gateway-api/echo-basic:v1.5.1
Error response from daemon: manifest for registry.k8s.io/gateway-api/echo-basic:v1.5.1 not found: manifest unknown: Failed to fetch "v1.5.1"
There was a problem hiding this comment.
I opened a PR promoting these missing images
| - --crt=/cert.crt | ||
| - --key=/cert.key | ||
| - name: echo | ||
| image: registry.k8s.io/gateway-api/echo-advanced:v1.5.1 |
There was a problem hiding this comment.
docker pull registry.k8s.io/gateway-api/echo-advanced:v1.5.1
Error response from daemon: manifest for registry.k8s.io/gateway-api/echo-advanced:v1.5.1 not found: manifest unknown: Failed to fetch "v1.5.1"
|
Those are the versions that we have: |
|
Before I backfill the images, I asked this question on Slack
|
|
echo-basic is for the north-south tests, while echo-advanced is for east-west mesh cases. You're correct that's it's a copy of the istio app image, the reason to do that was to move the the test artifact under Gateway API's control, rather than being under Istio's control. That way, the Gateway API conformance tests are not dependent on another organization's binary. |
| allowedRoutes: | ||
| namespaces: | ||
| from: Same | ||
| - name: http |
There was a problem hiding this comment.
I'm wondering why the whitespace changes weren't caught by the linter. Could you fix them anyway?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: upodroid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
6 participants
What type of PR is this?
/kind bug
What this PR does / why we need it:
All end-user facing images need to be served from registry.k8s.io, you can't serve any images hosted at
gcr.io/k8-staging-*orus-central1-docker.pkg.dev/k8s-staging-images/*to end users. The project has a policy for serving docker images to end users here.Unfortunately, we got hit with a large bill, and we need to shut down
gcr.io/k8s-staging-gateway-apias soon as possible. To do that:Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: