Skip to content

Use Kubernetes v1.34 and Kind v0.30 by default#289

Merged
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
nixpanic:k8s-v1.34
Dec 9, 2025
Merged

Use Kubernetes v1.34 and Kind v0.30 by default#289
k8s-ci-robot merged 1 commit into
kubernetes-csi:masterfrom
nixpanic:k8s-v1.34

Conversation

@nixpanic
Copy link
Copy Markdown
Member

@nixpanic nixpanic commented Dec 8, 2025

After a recent Docker update, the CI jobs fail during kind build node-image. This has been addressed in kubernetes/kubernetes#135575, but only for the maintained Kubernetes releases.

It seems release-tools/prow.sh uses Kubernetes v1.22.0, which isn't supported anymore, and hence not fixed. Updating the Kubernetes version in prow.sh and using the most recent Kind version should make the CI jobs succeed again.

Examples of jobs that failed:

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 8, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 8, 2025
@nixpanic nixpanic changed the title Use Kubernetes v1.34 and Kubd v0.30 by default Use Kubernetes v1.34 and Kind v0.30 by default Dec 8, 2025
@gnufied
Copy link
Copy Markdown
Contributor

gnufied commented Dec 8, 2025

So no sidecar should be using v1.22 kubernetes anymore. The defaults in release-tools are replaced by sidecars or the test-infra YAMLs. The error:


+++ [1208 11:00:58] Building Docker image kube-build:build-f02a2c1af0-5-v1.34.0-go1.24.6-bullseye.0
WARNING: This output is designed for human readability. For machine-readable output, please use --format.
+++ [1208 11:02:54] Creating data container kube-build-data-f02a2c1af0-5-v1.34.0-go1.24.6-bullseye.0
+++ [1208 11:02:56] Syncing sources to container
template parsing error: template: :1:19: executing "" at <.NetworkSettings.IPAddress>: map has no entry for key "IPAddress"
!!! [1208 11:02:56] Call tree:

is coming while building v1.34 kube-build image right? I am fine with upgrading kind version but we can't harcode to v1.34 because technically we still have to support v1.33 and v1.32 .

If we must bump kubernetes we can bump to v1.32 or v1.31 or something, but I am not sure if that is the root cause of the problem.

@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Dec 8, 2025

The fix is in a build script from the k/k repository. I think the falling jobs do checkout k/k v1.22.0 which contains an old version of the script.

See kubernetes/kubernetes#135576 for the ip-address parsing change for the new Docker version.

@xing-yang
Copy link
Copy Markdown
Contributor

Can you test this change by submitting a test PR to external-provisioner and external-resizer?

@nixpanic
Copy link
Copy Markdown
Member Author

nixpanic commented Dec 9, 2025

Can you test this change by submitting a test PR to external-provisioner and external-resizer?

Sure!

Both passed all tests now 🥳

@gnufied
Copy link
Copy Markdown
Contributor

gnufied commented Dec 9, 2025

Okay lets merge this. We can come back to it, if it still fails. Thanks for opening verification PRs for external-resizer repos etc.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2025
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@k8s-ci-robot k8s-ci-robot merged commit b12e407 into kubernetes-csi:master Dec 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants