Use Kubernetes v1.34 and Kind v0.30 by default#289
Conversation
|
So no sidecar should be using v1.22 kubernetes anymore. The defaults in release-tools are replaced by sidecars or the test-infra YAMLs. The error: is coming while building v1.34 kube-build image right? I am fine with upgrading kind version but we can't harcode to v1.34 because technically we still have to support v1.33 and v1.32 . If we must bump kubernetes we can bump to v1.32 or v1.31 or something, but I am not sure if that is the root cause of the problem. |
|
The fix is in a build script from the k/k repository. I think the falling jobs do checkout k/k v1.22.0 which contains an old version of the script. See kubernetes/kubernetes#135576 for the ip-address parsing change for the new Docker version. |
|
Can you test this change by submitting a test PR to external-provisioner and external-resizer? |
Sure!
Both passed all tests now 🥳 |
|
Okay lets merge this. We can come back to it, if it still fails. Thanks for opening verification PRs for external-resizer repos etc. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied, nixpanic The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After a recent Docker update, the CI jobs fail during
kind build node-image. This has been addressed in kubernetes/kubernetes#135575, but only for the maintained Kubernetes releases.It seems
release-tools/prow.shuses Kubernetes v1.22.0, which isn't supported anymore, and hence not fixed. Updating the Kubernetes version inprow.shand using the most recent Kind version should make the CI jobs succeed again.Examples of jobs that failed: