upgraded workspace to Rust 2024 edition syntax semantics and rust 1.96 toolchain#88
Open
arthurianresolve wants to merge 1 commit into
Open
upgraded workspace to Rust 2024 edition syntax semantics and rust 1.96 toolchain#88arthurianresolve wants to merge 1 commit into
arthurianresolve wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded to current Latest Stable Syntax and Toolchain:
Rust 2021->Rust 2024 editionrust 1.96.0Code review findings fixed
edition = "2021".dsrs::predict_accessorused a macro-export path pattern that Rust reports as future-incompatible.jsonishparser sites had Rust 2024 tail-expression drop-order warnings.Validation passed on Rust
1.96.0:rustc 1.96.0,cargo 1.96.0cargo fmt --allcargo check --workspace --all-targets --all-features --future-incompat-reportcargo test -p baml-ids --all-featurescargo test --workspace --all-features --no-runcargo test -p bstd project_fqn --all-features -- --nocapturecargo test -p dspy-rs named_parameters --all-features -- --nocapturecargo test -p jsonish --lib --all-features markdown -- --nocapturecargo test -p jsonish --lib --all-features multi_json -- --nocapturegit diff --checkrg -n "expr_2021|pat_param|keyword_idents_2024" -g "*.rs"found nothing