-
Notifications
You must be signed in to change notification settings - Fork 9
feat(deploy): 添加自定义 Maven 命令功能 #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ccwxl
wants to merge
5
commits into
koupleless:main
Choose a base branch
from
ccwxl:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /** | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package deploy | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/google/go-cmp/cmp" | ||
| ) | ||
|
|
||
| func TestParseMavenCommand(t *testing.T) { | ||
| t.Parallel() | ||
|
|
||
| defaultArgs := append([]string(nil), defaultMavenArgs...) | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| mvnCmd string | ||
| wantCmd string | ||
| wantArgs []string | ||
| }{ | ||
| { | ||
| name: "empty command", | ||
| mvnCmd: "", | ||
| wantCmd: defaultMavenCmd, | ||
| wantArgs: defaultArgs, | ||
| }, | ||
| { | ||
| name: "custom command without args", | ||
| mvnCmd: "mvnw", | ||
| wantCmd: "mvnw", | ||
| wantArgs: []string{}, | ||
| }, | ||
| { | ||
| name: "custom command with args", | ||
| mvnCmd: "mvn clean install", | ||
| wantCmd: "mvn", | ||
| wantArgs: []string{"clean", "install"}, | ||
| }, | ||
| { | ||
| name: "complex command with args", | ||
| mvnCmd: "mvnw clean package -DskipTests", | ||
| wantCmd: "mvnw", | ||
| wantArgs: []string{"clean", "package", "-DskipTests"}, | ||
| }, | ||
| { | ||
| name: "command with multiple spaces", | ||
| mvnCmd: "mvn clean package", | ||
| wantCmd: "mvn", | ||
| wantArgs: []string{"clean", "package"}, | ||
| }, | ||
| { | ||
| name: "whitespace-only command", | ||
| mvnCmd: " \t\n ", | ||
| wantCmd: defaultMavenCmd, | ||
| wantArgs: defaultArgs, | ||
| }, | ||
| { | ||
| name: "leading and trailing spaces", | ||
| mvnCmd: " mvn clean package ", | ||
| wantCmd: "mvn", | ||
| wantArgs: []string{"clean", "package"}, | ||
| }, | ||
| { | ||
| name: "tabs between tokens", | ||
| mvnCmd: "mvn\tclean\tinstall", | ||
| wantCmd: "mvn", | ||
| wantArgs: []string{"clean", "install"}, | ||
| }, | ||
| { | ||
| name: "windows wrapper with flags", | ||
| mvnCmd: "mvnw.cmd -q -T1C", | ||
| wantCmd: "mvnw.cmd", | ||
| wantArgs: []string{"-q", "-T1C"}, | ||
| }, | ||
| { | ||
| name: "absolute path mvn", | ||
| mvnCmd: "/usr/local/bin/mvn -q", | ||
| wantCmd: "/usr/local/bin/mvn", | ||
| wantArgs: []string{"-q"}, | ||
| }, | ||
| { | ||
| name: "relative path wrapper", | ||
| mvnCmd: "./mvnw -q", | ||
| wantCmd: "./mvnw", | ||
| wantArgs: []string{"-q"}, | ||
| }, | ||
| { | ||
| name: "args with equals and profile", | ||
| mvnCmd: "mvn -DskipTests=true -Pprod", | ||
| wantCmd: "mvn", | ||
| wantArgs: []string{"-DskipTests=true", "-Pprod"}, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| tt := tt | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| t.Parallel() | ||
| gotCmd, gotArgs := parseMavenCommand(tt.mvnCmd) | ||
| if gotCmd != tt.wantCmd { | ||
| t.Errorf("parseMavenCommand() gotCmd = %q, want %q", gotCmd, tt.wantCmd) | ||
| } | ||
| if diff := cmp.Diff(tt.wantArgs, gotArgs); diff != "" { | ||
| t.Errorf("parseMavenCommand() args mismatch (-want +got):\n%s", diff) | ||
| } | ||
| }) | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Confirm golang.org/x/text version and security posture.
You moved x/text to a direct dependency at v0.14.0. Please verify if a newer patch/minor is available and whether any advisories apply.
Run:
🏁 Script executed:
Length of output: 2404
Update x/text dependency to the latest release and verify security posture
govulncheck golang.org/x/text@v0.28.0orgo list -m -u -json golang.org/x/text@v0.28.0) to confirm no advisories applyProposed diff:
📝 Committable suggestion