Skip to content

views: fix finalization for subview #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IvanGrigorik wants to merge 2 commits into
base: main
Choose a base branch
from
Open

views: fix finalization for subview #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d6c9e8
fix finalization for subview
IvanGrigorik Mar 22, 2026
47f68ff
fmt
IvanGrigorik Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pykokkos/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ def cleanup():
view.array = None
if hasattr(view, "data"):
view.data = None
if hasattr(view, "xp_array"):
view.xp_array = None
except (ReferenceError, AttributeError):
pass

Expand Down
7 changes: 7 additions & 0 deletions pykokkos/interface/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,13 @@ def __init__(
self.ndim = self.data.ndim
self.size = self.data.size

try:
from pykokkos import _view_registry

_view_registry.add(self)
except (ImportError, AttributeError):
pass
Comment on lines +635 to +636
Copy link
Copy Markdown
Collaborator

@kennykos kennykos Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, why would get ImportError or AttributeError here?


def _create_slice(self, data_slice: Union[slice, Tuple]) -> List[Union[int, slice]]:
"""
Transforms the slice into a list, removing all None values for start and stop
Expand Down
Loading