Add Blas Concepts#2944
Open
yasahi-hpc wants to merge 3 commits into
Open
Conversation
lucbv
requested changes
Feb 19, 2026
Contributor
lucbv
left a comment
There was a problem hiding this comment.
It looks good overall but I think at least one more test to exemplify how this will work in practice would be nice : )
Contributor
There was a problem hiding this comment.
Can we add a test where we actually use the concept, i.e. create a dummy class/struct with a requirement close and observe that it goes well?
Contributor
Author
There was a problem hiding this comment.
I added a dummy functor to explain the typical use case in mind
Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
6b6bbd7 to
05c3495
Compare
Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
05c3495 to
c5e3bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces concepts from
KokkosBlastraits which are planed to be used inKokkosBatched.Currently, we only have the following concepts.
Similar concepts should be defined for
KokkosBatched