Skip to content

Add Blas Concepts#2944

Open
yasahi-hpc wants to merge 3 commits into
kokkos:developfrom
yasahi-hpc:add-blas-concepts
Open

Add Blas Concepts#2944
yasahi-hpc wants to merge 3 commits into
kokkos:developfrom
yasahi-hpc:add-blas-concepts

Conversation

@yasahi-hpc
Copy link
Copy Markdown
Contributor

This PR introduces concepts from KokkosBlas traits which are planed to be used in KokkosBatched.
Currently, we only have the following concepts.
Similar concepts should be defined for KokkosBatched

template <typename T>
concept TransposeOperation = is_trans_v<T>;

template <typename T>
concept BlasLevel2 = is_level2_v<T>;

template <typename T>
concept BlasLevel3 = is_level3_v<T>;

@yasahi-hpc yasahi-hpc self-assigned this Feb 17, 2026
@yasahi-hpc yasahi-hpc marked this pull request as draft February 17, 2026 20:12
Copy link
Copy Markdown
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall but I think at least one more test to exemplify how this will work in practice would be nice : )

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test where we actually use the concept, i.e. create a dummy class/struct with a requirement close and observe that it goes well?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a dummy functor to explain the typical use case in mind

Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
Signed-off-by: yasahi-hpc <y.asahi6412@gmail.com>
@yasahi-hpc yasahi-hpc marked this pull request as ready for review February 20, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants