[test] don't pass the t's logger to the adapter#9016
Open
maschmid wants to merge 1 commit intoknative:mainfrom
Open
[test] don't pass the t's logger to the adapter#9016maschmid wants to merge 1 commit intoknative:mainfrom
maschmid wants to merge 1 commit intoknative:mainfrom
Conversation
as the adapter may still run and log with the logger after the test is done, thus causing a data race
knative-prow
bot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maschmid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9016 +/- ##
=======================================
Coverage 51.04% 51.04%
=======================================
Files 409 409
Lines 21986 21986
=======================================
Hits 11223 11223
Misses 9902 9902
Partials 861 861 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing a data race, as seen e.g. in https://prow.knative.dev/view/gcs/knative-prow/logs/continuous_eventing_main_periodic/2042044786172497920
don't tie the test context's logger to the adapter. The failFast adapter
Startby design terminates as soon as the first watch failure occurs, so it doesn't wait for the other watches to stop. Thea.logger.Error("reflector exited: %v", err)may then be invoked on the test logger after the test has already finished, thus causing a "data race"