Skip to content

fix: allow creating campaign drafts without lists assigned #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Danimarqz wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Open

fix: allow creating campaign drafts without lists assigned #3015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions cmd/campaigns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,17 @@ func (a *App) UpdateCampaignStatus(c echo.Context) error {
return err
}

// Lists are only required when starting or scheduling a campaign, not for drafts.
if req.Status == models.CampaignStatusRunning || req.Status == models.CampaignStatusScheduled {
camp, err := a.core.GetCampaign(id, "", "")
if err != nil {
return err
}
if len(camp.Lists) == 0 {
return echo.NewHTTPError(http.StatusBadRequest, a.i18n.T("campaigns.fieldInvalidListIDs"))
}
}

// Update the campaign status in the DB.
out, err := a.core.UpdateCampaignStatus(id, req.Status)
if err != nil {
Expand Down Expand Up @@ -698,9 +709,6 @@ func (a *App) validateCampaignFields(c campReq) (campReq, error) {
}
}

if len(c.ListIDs) == 0 {
return c, errors.New(a.i18n.T("campaigns.fieldInvalidListIDs"))
}

if !a.manager.HasMessenger(c.Messenger) {
// If it's a specific SMTP, but it's no longer available (removed/disabled), fall back to general email messenger.
Expand Down