fix(core): clone state actions deep copy#15961
Draft
rc-swag wants to merge 10 commits into
Draft
Conversation
add apply_actions_and_merge_app_context to km_core_event parent. This ensures any actions as result of the km_core_event are applied and actions object updated. Fixes:#15857
… fix/windows/15857/caps-indicator-switched-off-select
This commit update the state object to have a deep copy for the action_struct member. The tests have been modified but have a few issues however this branch is out of date with the refacted master branch for unit tests. This commit gets the main change in a future commit will update the tests.
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In review of #15947 it was noted there was an existing issue with
_actionslist. Theactions->optionsare going to point to the the original_option_items_stackvector. In practice this is unlikely to cause problems because_actionscleared and rebuilt on the nextkm_core_process_eventcall. I have made the change to the core code actions::actions(actions const &other)I need to add unit tests for it to be complete.
You can see my first attempt at testing in the commented out code in