Skip to content

chore: khmer translation now uses busra font #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Meng-Heng wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −0
Open

chore: khmer translation now uses busra font #752

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7f6ee5
chore: khmer translation now uses busra font
Meng-Heng May 21, 2026
4730630
chore: move lang(km) under lang(lao)
Meng-Heng May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cdn/dev/css/template.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,20 @@ html {
src: url('//s.keyman.com/font/deploy/LateefRegOT.ttf') format("truetype");
}

@font-face {
font-family: Busra;
font-style: normal;
font-weight: normal;
src: url('//s.keyman.com/font/deploy/Busra-Regular.ttf') format("truetype");
unicode-range: U+1780-17FF, U+19E0-19FF;
}

/* Khmer */
:lang(km) {
/* The browser will automatically use Busra for Khmer chars and Cabin or Sans-serif for others */
font-family: 'Busra','Cabin', sans-serif;
}

Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. For maintainability, can we move this alphabetically before Lao (line 289)?

  2. I don't know CSS. Are Cabin and sans-serif already handled in line 173? (I note the other languages only reference one font for family, and not in quotes)

Copy link
Copy Markdown
Collaborator Author

@Meng-Heng Meng-Heng May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try removing the two fonts to see if Busra is working properly or not. I added the Unicode range after font-family so this might fix it without having to specify three fonts.

Copy link
Copy Markdown
Collaborator Author

@Meng-Heng Meng-Heng May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got the answer now. The Cabin and sans-serif fonts are there as a fallback for other characters that aren't Khmer.

Since I use lang(km) to recognize the km in the URL (http://keyman.com.localhost:8053/km/keyboards/?q=k&x=0&y=0) to trigger a font change, it changes the font for the entire web page.

Busra font:
Screenshot 2026-05-22 at 5 02 50 in the afternoon

keyman.com:
Screenshot 2026-05-22 at 5 03 17 in the afternoon

Whereas the other font-family properties are being used for .lang-example selectors, so it does not impact any other elements; therefore, one value for font-family is enough.

/* Amharic */
:lang(amh).lang-example {
font-family: GeezWeb;
Expand Down
Loading