Some additions to FCCSWEndcapTurbine_k4geo. - #567
Merged
Conversation
Add some missing FieldName methods. nModules() shoud be const.
scott-snyder
requested review from
BrieucF,
andresailer,
gaede,
jmcarcell and
tmadlener
as code owners
February 22, 2026 19:29
Collaborator
Author
|
Failure not due to this change; should be fixed by HEP-FCC/FCCSW#491 |
mattiasoldani
pushed a commit
to mattiasoldani/k4geo
that referenced
this pull request
Jul 28, 2026
Add some missing FieldName methods. nModules() shoud be const. Co-authored-by: sss <sss@karma> Co-authored-by: Giovanni Marchiori <39376142+giovannimarchiori@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some missing FieldName methods.
nModules() shoud be const.
BEGINRELEASENOTES
ENDRELEASENOTES