Don't require equality_comparable in putParameter - #417
Closed
ianna wants to merge 1 commit into
Closed
Conversation
Author
|
@jmcarcell and @andresailer - this should allow all tests pass for #372 |
Member
|
That has already been fixed in EDM4hep: key4hep/EDM4hep#497 but that change is not in the latest tag/release. The change here would silently ignore anything that doesn't have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the build against recent EDM4hep, where
edm4hep::utils::ParticleIDMetais no longerstd::equality_comparable(itsalgoTypemember became private, removing the defaultedoperator==).putParameterrequired that concept only for the*existing == valuecomparison behindskipIfSameValue().This relaxes the template constraint and guards the comparison with
if constexpr (std::equality_comparable<T>). For non-comparable metadata types the "skip if identical value" shortcut is bypassed; all other behaviour is unchanged.BEGINRELEASENOTES
putParameterwith metadata types that are notstd::equality_comparable(e.g.edm4hep::utils::ParticleIDMetain recent EDM4hep). TheskipIfSameValue()optimization is now only applied when the type supports==.ENDRELEASENOTES