Skip to content

Properly propagate input cellID encodings to outputs - #78

Merged
jmcarcell merged 4 commits into
key4hep:mainfrom
tmadlener:fix-cellid-encoding-setting
May 13, 2026
Merged

Properly propagate input cellID encodings to outputs#78
jmcarcell merged 4 commits into
key4hep:mainfrom
tmadlener:fix-cellid-encoding-setting

Conversation

@tmadlener

@tmadlener tmadlener commented Apr 28, 2026

Copy link
Copy Markdown
Member

BEGINRELEASENOTES

ENDRELEASENOTES

Noticed this in the downstream build of k4MarlinWrapper

The hardcoded collection does not exist in the input file. Use the input
collection instead
@tmadlener

Copy link
Copy Markdown
Member Author

I don't know how the tests can currently run because EcalBarrelCollection does not exist in the input file it is ECalBarrelCollection. e.g.

$ podio-dump -c metadata build/test/input_files/20240905_gammaFromVertex_10GeV_uniform_10events_reco_edm4hep.root | grep -i ecalbarrel
Warning in <TClass::Init>: no dictionary for class edm4hep::Vector2i is available
ECALBarrel__CellIDEncoding                    std::string  1         
ECalBarrelCollection__CellIDEncoding          std::string  1         

I have changed this to use one of the input collections instead, so we have higher chances of propagating the correct input encoding.

@tmadlener tmadlener changed the title Set CellID encoding strings in initialize Properly propagate input cellID encodings to outputs Apr 28, 2026
@jmcarcell

Copy link
Copy Markdown
Member

I think you got confused, there is no Ecal... collection with lowercase c in the original code, but it is there in your intermediate commits. The tests never succeeded with it, but the comment above implies otherwise.

Other than that, the PR looks good.

@jmcarcell
jmcarcell merged commit 5c715af into key4hep:main May 13, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants