Properly propagate input cellID encodings to outputs - #78
Merged
Conversation
Doing it during the event loop no longer works
2 tasks
The hardcoded collection does not exist in the input file. Use the input collection instead
Member
Author
|
I don't know how the tests can currently run because $ podio-dump -c metadata build/test/input_files/20240905_gammaFromVertex_10GeV_uniform_10events_reco_edm4hep.root | grep -i ecalbarrel
Warning in <TClass::Init>: no dictionary for class edm4hep::Vector2i is available
ECALBarrel__CellIDEncoding std::string 1
ECalBarrelCollection__CellIDEncoding std::string 1 I have changed this to use one of the input collections instead, so we have higher chances of propagating the correct input encoding. |
Member
|
I think you got confused, there is no Other than that, the PR looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
initializeas doing it during the event loop will no longer work (see key4hep/k4FWCore#400ENDRELEASENOTES
Noticed this in the downstream build of k4MarlinWrapper