Add in-memory DD4hep to Acts Geo Gen3 conversion - #36
Conversation
bfc300c to
bccc01e
Compare
2f654fa to
18b5f4f
Compare
e1c026b to
c0622b8
Compare
|
|
||
| /// A simple struct to hold configuration to build a tracker that is nested | ||
| /// such that a simple stacking in z does not work. | ||
| struct NestedInnerTrackerSpec { |
There was a problem hiding this comment.
Do you think something like this should exist at the library level?
There was a problem hiding this comment.
I am not entirely sure. I don't see a way to make this general enough to be useful without inventing another semi DSL just for this purpose. This specific thing works for our case, where there is one (or a few) endcap layers that protrude into the cylinder formed by the outermost barrel layer(s). However, we currently only have this nesting once (in a subdetector). As soon as we have, e.g. two different levels of protrusion it no longer works. The way out would be to simply call this thing twice with different configurations, but then one would have to potentially add more config, e.g. to allow for "empty" layers.
Given that it's fairly straight forward to build this on our end on top of the proposed API, I would keep it in "userland" and see if it's common enough there to merit upstreaming later.
5933a8a to
8197a6e
Compare
|
With the changes in paulgessinger/acts#33 we now also support planar geometries, like LUXE |
8197a6e to
17edab4
Compare
e76aa62 to
d8ea41c
Compare
d8ea41c to
e3604db
Compare
|
Key4hep nightlies are building, only tests are failing now. Looking into them. This is ready for review in any case. |
|
Most of the geometries do not yet use the "hierarchical" drivers that are assumed for most of the tests here. These are done in key4hep/k4geo#579 I could switch the conversion code to work with the older versions and then we switch back to this version once we have them in place. |
8f50065 to
07ea68b
Compare
|
The artifact uploading will eventually have to move to the upstream action. See also the discussion in key4hep/key4hep-actions#39 |
23f9671 to
c8a1512
Compare
|
This is now in a quite decent stage from my point of view. It converts the advertised geometries as they currently appear in k4geo (nightlies). I have checked the produced The one thing that is not yet full working here is the I am fairly happy with the utility functionality in the I will update #49 with some tests for all the converted geometries to establish basic tracking. We can discuss how we want to proceed with these PRs. I would have a preference to get at least some basic functionality in on which it is then possible to iterate, but we can discuss this. |
Either absorbed by other services or not part of the context of this PR
Make sure that the resulting mapping will work as expected
InnerTrackerEndcaps have to be stacked along z after the stacking on the VertexBarrel along r
Functionality has not landed in Acts yet and we can work around it for now
Done via Claude (Opus 4.7 for plan, Sonnet 4.6 for execution)
244f25c to
f939537
Compare
BEGINRELEASENOTES
ActsGeoSvcto do the conversion from DD4hep to ACTS Gen3 geometry in-memory via the ACTS blueprint API. This does not yet update any tracking functionality, it only adds geometry conversion(0, 0, 0)from the DD4hep geometryMAIA_v0,MuSIC_v2ILD_FCCee_v01,ILD_FCCee_v02,CLD_o2_v08,CLD_o2_v07LUXE_v0(lives in https://github.com/LUXESoftware/luxegeo)ENDRELEASENOTES
This is a work in progress with the main purpose of being able to share ongoing efforts. So far the efforts focus on getting (parts) of the
MAIA_v0geometry conversion tested and evaluated against upstream work happening at currently living on https://github.com/paulgessinger/acts/tree/feat/dd4hep-gen3For the
MAIA_v0geometry, this needs key4hep/k4geo#549