docs(migration): warn against secrets metadata migration in read-only mode - #5462
Open
nkwiatkowski wants to merge 2 commits into
Open
docs(migration): warn against secrets metadata migration in read-only mode#5462nkwiatkowski wants to merge 2 commits into
nkwiatkowski wants to merge 2 commits into
Conversation
… mode The secrets metadata migration cannot run when the secret manager is in read-only mode and now fails on purpose there. Document that skipping it in that case is expected and safe. Closes https://github.com/kestra-io/kestra-ee/issues/10630.
Contributor
☁️ Cloudflare Worker Preview Deployed!🔗 https://ks-fix-10630-secret-migration-rea-docs.kestra-io.workers.dev 🔦 Lighthouse Benchmark
Scores (0–100, higher is better)
Core Web Vitals (lower is better)
Legend🟢 improved · 🔻 regressed · (blank) no significant change View full Lighthouse HTML report for a pageFull per-page Lighthouse Results (LHR) are attached as the |
…cret migration The secrets metadata migration now skips read-only tenants/namespaces and logs them, while migrating writable ones. Document this instead of telling users not to run it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The metadata migration guides don't mention that
kestra migrate metadata secretscannot run when the secret manager is in read-only mode. A customer running AWS Secrets Manager in read-only (scoped) mode hit a crypticsecretsmanager:GetSecretValuepermission error and was unsure whether it was a blocker.Fix
Add a warning to both the 1.3 LTS migration guide and the 1.1 KV & Secrets metadata migration guide: read-only secret managers do not use the secrets metadata store, so the migration is neither needed nor supported, and skipping it is expected and safe.
Evidence
Companion code PR (which makes the command fail with a clear message in read-only mode): kestra-io/kestra-ee#10631.
Closes https://github.com/kestra-io/kestra-ee/issues/10630.