Remove empty names from generated sbom - #1652
Merged
Merged
Conversation
show-info walks TARGETS_ROOTFS, but the image and qemu targets set only _DIR. They come out nameless and land in the SBOM with an empty bom-ref, which CycloneDX 1.6 rejects. Set _NAME and _TYPE too, as fs/common.mk does for rootfs targets. Signed-off-by: Ejub Sabic <ejub1946@outlook.com>
Contributor
|
@saba8814 This change is very unlikely to affect the resulting image. So please "skip" the test runs on http://monza/styx/ and http://monza/alder/ when ghmoon picks them up as TODO jobs. Tip We can also set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
show-info walks TARGETS_ROOTFS, but the image and qemu targets set only _DIR. They come out nameless and land in the SBOM with an empty bom-ref, which CycloneDX 1.6 rejects. Set _NAME and _TYPE too, as fs/common.mk does for rootfs targets.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: