Skip to content

Remove empty names from generated sbom - #1652

Merged
troglobit merged 1 commit into
kernelkit:mainfrom
saba8814:fix/fail-when-generating-sbom
Sep 23, 2026
Merged

troglobit merged 1 commit into
kernelkit:mainfrom
saba8814:fix/fail-when-generating-sbom

Conversation

@saba8814

Copy link
Copy Markdown
Collaborator

show-info walks TARGETS_ROOTFS, but the image and qemu targets set only _DIR. They come out nameless and land in the SBOM with an empty bom-ref, which CycloneDX 1.6 rejects. Set _NAME and _TYPE too, as fs/common.mk does for rootfs targets.

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

show-info walks TARGETS_ROOTFS, but the image and qemu targets set only
_DIR.  They come out nameless and land in the SBOM with an empty
bom-ref, which CycloneDX 1.6 rejects.  Set _NAME and _TYPE too, as
fs/common.mk does for rootfs targets.

Signed-off-by: Ejub Sabic <ejub1946@outlook.com>

@troglobit troglobit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@troglobit

Copy link
Copy Markdown
Contributor

@saba8814 This change is very unlikely to affect the resulting image. So please "skip" the test runs on http://monza/styx/ and http://monza/alder/ when ghmoon picks them up as TODO jobs.

Tip

We can also set [skip ci] on changes like this. I'm also introducing a ci:skip label that can be added before/after fixing up, e.g., ChangeLog conflicts and jobs like this one. This will soon be available on main.

@jovatn jovatn added the cn:styx Common Name: Styx Project label Sep 23, 2026
@troglobit
troglobit merged commit bedd2fc into kernelkit:main Sep 23, 2026
14 checks passed
@saba8814
saba8814 deleted the fix/fail-when-generating-sbom branch September 30, 2026 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cn:styx Common Name: Styx Project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants