Skip to content

fix(helm): add explicit namespace to all resource templates #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Smana wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(helm): add explicit namespace to all resource templates #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/keep/templates/backend-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "keep.fullname" . }}-backend
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: backend
Expand Down
2 changes: 2 additions & 0 deletions charts/keep/templates/backend-provision.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: v1
kind: Secret
metadata:
name: {{ include "keep.fullname" . }}-providers
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: backend
Expand All @@ -19,6 +20,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "keep.fullname" . }}-workflows
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: backend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/backend-route.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: route.openshift.io/v1
kind: Route
metadata:
name: {{ $fullName }}
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: backend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/backend-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "keep.fullname" . }}-backend
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: backend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "keep.fullname" . }}-backend
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: backend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/db-cleanup-cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: batch/v1
kind: CronJob
metadata:
name: {{ include "keep.fullname" . }}-db-cleanup
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: database
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/db-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ConfigMap
metadata:
name: {{ include "keep.fullname" . }}-mysql-config
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: database
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/db-pvc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ apiVersion: v1
kind: PersistentVolumeClaim
metadata:
name: {{ $pvcName }}
namespace: {{ include "keep.namespace" . }}
annotations:
{{- if .Values.database.pvc.retain }}
helm.sh/resource-policy: keep
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/db-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "keep.name" . }}-database
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: database
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/db.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "keep.fullname" . }}-database
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: database
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/delete-secret-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ apiVersion: batch/v1
kind: Job
metadata:
name: delete-keep-secrets
namespace: {{ include "keep.namespace" . }}
annotations:
"helm.sh/hook": pre-delete
"helm.sh/hook-delete-policy": "hook-succeeded,hook-failed"
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/frontend-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "keep.fullname" . }}-frontend
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: frontend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/frontend-route.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: route.openshift.io/v1
kind: Route
metadata:
name: {{ $fullName }}
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: frontend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/frontend-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "keep.fullname" . }}-frontend
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: frontend
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/frontend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "keep.fullname" . }}-frontend
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: frontend
Expand Down
2 changes: 1 addition & 1 deletion charts/keep/templates/gke/backend-gke-healthcheck-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: cloud.google.com/v1
kind: BackendConfig
metadata:
name: {{ include "keep.fullname" . }}-backend-backendconfig
namespace: {{ .Release.Namespace }}
namespace: {{ include "keep.namespace" . }}
spec:
healthCheck:
checkIntervalSec: {{ .Values.frontend.backendConfig.healthCheck.checkIntervalSec }}
Expand Down
2 changes: 1 addition & 1 deletion charts/keep/templates/gke/frontend-gke-healthcheck-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: cloud.google.com/v1
kind: BackendConfig
metadata:
name: {{ include "keep.fullname" . }}-frontend-backendconfig
namespace: {{ .Release.Namespace }}
namespace: {{ include "keep.namespace" . }}
spec:
healthCheck:
checkIntervalSec: {{ .Values.frontend.backendConfig.healthCheck.checkIntervalSec }}
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/ingress-haproxy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}-ingress
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: networking
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/ingress-nginx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}-ingress
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: networking
Expand Down
2 changes: 1 addition & 1 deletion charts/keep/templates/ingress-traefik-middleware.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: traefik.io/v1alpha1
kind: Middleware
metadata:
name: strip-prefix
namespace: {{ .Release.Namespace }}
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: networking
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/ingress-traefik.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: {{ $fullName }}-ingress
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: networking
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ include "keep.serviceAccountName" . }}
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: rbac
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/websocket-hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: autoscaling/v2
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "keep.fullname" . }}-websocket
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: websocket
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/websocket-route.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ apiVersion: route.openshift.io/v1
kind: Route
metadata:
name: {{ $fullName }}-websocket
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: websocket
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/websocket-server-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: v1
kind: Service
metadata:
name: {{ include "keep.fullname" . }}-websocket
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: websocket
Expand Down
1 change: 1 addition & 0 deletions charts/keep/templates/websocket-server.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
name: {{ include "keep.fullname" . }}-websocket
namespace: {{ include "keep.namespace" . }}
labels:
{{- include "keep.labels" . | nindent 4 }}
app.kubernetes.io/component: websocket
Expand Down