Skip to content

feat: update dataset docstring for dask#1332

Merged
merelcht merged 9 commits intokedro-org:mainfrom
rgunasekaran-github:feat/update-dataset-docstring-for-dask
Apr 28, 2026
Merged

feat: update dataset docstring for dask#1332
merelcht merged 9 commits intokedro-org:mainfrom
rgunasekaran-github:feat/update-dataset-docstring-for-dask

Conversation

@rgunasekaran-github
Copy link
Copy Markdown
Contributor

Description

this PR is created for updating the docstrings to point out that filepath type is str | os.PathLike

Development notes

filepath: str | os.PathLike,

Checklist

  • [ x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Updated jsonschema/kedro-catalog-X.XX.json if necessary
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes
  • Received approvals from at least half of the TSC (required for adding a new, non-experimental dataset)

@rgunasekaran-github rgunasekaran-github changed the title Feat/update dataset docstring for dask feat/update dataset docstring for dask Feb 27, 2026
@rgunasekaran-github rgunasekaran-github changed the title feat/update dataset docstring for dask feat: update dataset docstring for dask Feb 27, 2026
Signed-off-by: Rajesh Gunasekaran <grajesh.ec@gmail.com>
Signed-off-by: Rajesh Gunasekaran <grajesh.ec@gmail.com>
@rgunasekaran-github rgunasekaran-github force-pushed the feat/update-dataset-docstring-for-dask branch from 7bc31c3 to b0a9c4a Compare February 27, 2026 18:31
@SajidAlamQB
Copy link
Copy Markdown
Contributor

Hi, thanks for the contribution! 🎉

To fix the linter failure, you'll need to run the following from the repo root:

make plugin=kedro-datasets install-lint-requirements
make plugin=kedro-datasets lint

The linter will likely flag the import os placement it should be grouped with the stdlib imports at the top (before dask, fsspec, etc.), sorted alphabetically. Once you run the linter it should tell you exactly what to fix, or may even auto-fix it for you.

@lrcouto
Copy link
Copy Markdown
Contributor

lrcouto commented Feb 27, 2026

Hey, @rgunasekaran-github! Thanks for the PR!

It looks like commit a7ff525 includes some files that aren't related to the task. This usually happens when using git add ., stagging all modified files.

You could reset your git branch to the latest commit before this change and add only the ones related to the task, and then lint and push again. Let me know if you need any assistance on how to do this.

@ravi-kumar-pilla
Copy link
Copy Markdown
Contributor

Hi @rgunasekaran-github ,

Thank you for contributing. Would you be able to make the required changes as suggested in the comments ?

@rgunasekaran-github rgunasekaran-github force-pushed the feat/update-dataset-docstring-for-dask branch from 938d212 to 83f15c1 Compare March 9, 2026 21:45
@merelcht merelcht requested a review from lrcouto April 28, 2026 13:13
merelcht and others added 2 commits April 28, 2026 16:51
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht merged commit 30ca73a into kedro-org:main Apr 28, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants