Not running govet or gofmt in Dockerfile builds

[arschles]

Since we have code quality checks on the v2 branch, they will run prior to any docker build operation. That means that the go fmt and go vet calls inside the Dockerfile are redundant. This change removes them by creating two new makefile targets: adapter-dockerfile and manager-dockerfile, and changing the adapter and manager dockerfiles to call those two targets, respectively.

This patch also adds go vet to the pre-commit config file.

Question: should we add go vet to the golangci config file? This way, we can avoid running go fmt and go vet explicitly in the pre commit file, as it'll be done automatically by the pre-commit golangci hook

Checklist

• Commits are signed with Developer Certificate of Origin (DCO)
• Tests have been added
• A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
• Changelog has been updated

Fixes #1070

Notes about TODOs:

• Tests don't need to be added here
• No docs updates needed as well

Not sure about the changelog

[arschles]

The static check is failing because of the go-vet pre-commit hook. That code is here. We are working on a patch for that code, at which point we'll update this PR 😄

[arschles]

We have two patches proposed, hopefully the maintainer will choose one of them: dnephin/pre-commit-golang#63 and dnephin/pre-commit-golang#62

[zroubalik]

@arschles hi, any update on this?

[arschles]

@zroubalik sorry for the delay. I've been busy with the HTTP scaling work but I haven't forgotten about this. There's a US holiday this week and I'm going on vacation but I'll finish this up early next week.

[zroubalik]

@zroubalik sorry for the delay. I've been busy with the HTTP scaling work but I haven't forgotten about this. There's a US holiday this week and I'm going on vacation but I'll finish this up early next week.

No worries, enjoy your vacation! Thanks for the heads up :)

[arschles]

@zroubalik this comment suggests to just use golangci-lint in our CI (which already does a go vet). I think that would solve the problem nicely because right now, we're doing two go vet calls. What do you think?

[zroubalik]

@zroubalik this comment suggests to just use golangci-lint in our CI (which already does a go vet). I think that would solve the problem nicely because right now, we're doing two go vet calls. What do you think?

@arschles agree!

[arschles]

@zroubalik I removed the go-vet precommit check and things seem better now. PTAL

[zroubalik]

LGTM, thanks!

[arschles]

Thanks @zroubalik 😄