Skip to content

Update impasse_test_case_controller.rb #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cforce wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update impasse_test_case_controller.rb #222

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97c886c
Update impasse_test_case_controller.rb
cforce Oct 14, 2013
c207293
Update impasse_test_case_controller.rb
cforce Oct 14, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions app/controllers/impasse_test_case_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,23 @@ def new
save_keywords(@node, params[:node_keywords])
@test_case.id = @node.id
if @node.is_test_case? and params.include? :test_steps
@test_steps = params[:test_steps].collect{|i, ts| Impasse::TestStep.new(ts) }
#---------------------------------------------------------------------
# BUGFIX: <sorting test steps> sort test steps list correctly
# params[:test_steps] --> tmp_params (hash with key corresponding to the step number) --> tmp (sorted array)
#---------------------------------------------------------------------
tmp_params = Hash.new
params[:test_steps].each do |k,v|
k = "#{v['step_number']}"
tmp_params[("#{k}").to_i] = v
end
tmp = tmp_params.sort
tmp_params.clear
@test_steps = tmp.collect{|i, ts| Impasse::TestStep.new(ts) }
@test_steps.each{|ts| raise ActiveRecord::RecordInvalid.new(ts) unless ts.valid? }
@test_case.test_steps.replace(@test_steps)
tmp.clear
#</sorting test steps>
#---------------------------------------------------------------------
end
@test_case.save!
render :json => { :status => 'success', :message => l(:notice_successful_create), :ids => [@test_case.id] }
Expand Down Expand Up @@ -115,9 +129,23 @@ def edit
save_keywords(@node, params[:node_keywords])

if @node.is_test_case? and params.include? :test_steps
@test_steps = params[:test_steps].collect{|i, ts| Impasse::TestStep.new(ts) }
#---------------------------------------------------------------------
# BUGFIX: <sorting test steps> sort test steps list correctly
# params[:test_steps] --> tmp_params (hash with key corresponding to the step number) --> tmp (sorted array)
#---------------------------------------------------------------------
tmp_params = Hash.new
params[:test_steps].each do |k,v|
k = "#{v['step_number']}"
tmp_params[("#{k}").to_i] = v
end
tmp = tmp_params.sort
tmp_params.clear
@test_steps = tmp.collect{|i, ts| Impasse::TestStep.new(ts) }
@test_steps.each{|ts| raise ActiveRecord::RecordInvalid.new(ts) unless ts.valid? }
@test_case.test_steps.replace(@test_steps)
tmp.clear
#</sorting test steps>
#---------------------------------------------------------------------
end

if params[:attachments]
Expand Down