Skip to content

Improve the handling of multiple metric columns in datasets #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtuomist wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Improve the handling of multiple metric columns in datasets #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4ef14cd
Longmont: Move trends from actions to nodes; stop using historical ac…
jtuomist Jul 26, 2026
9d8bfec
Make DimensionalFlow.get_flow_node() more robust
jtuomist Jul 26, 2026
aae7c18
Longmont: Change ShiftActions to GenericActions with datasets
jtuomist Jul 26, 2026
cc7c612
Longmont: Fix additivity of building code and beyond building code
jtuomist Jul 26, 2026
27b27ca
Longmont: Make beyond_building_code match excel logic
jtuomist Jul 26, 2026
e0ad9be
Merge branch 'main' of https://github.com/kausaltech/kausal-paths
jtuomist Jul 27, 2026
805e74e
Longmont: Make benchmark_energy_use follow the excel logic to match v…
jtuomist Jul 27, 2026
e8e6b28
Improve handling of multiple metric columns in datasets
jtuomist Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions common/polars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import collections.abc
import re
import typing
from dataclasses import dataclass
Expand Down Expand Up @@ -181,6 +182,18 @@ def drop(
*columns: ColumnNameOrSelector | Iterable[ColumnNameOrSelector],
strict: bool = True,
) -> PathsDataFrame:
if strict:
requested: list[str] = []
for col in columns:
if isinstance(col, str):
requested.append(col)
elif isinstance(col, collections.abc.Iterable):
requested.extend(c for c in col if isinstance(c, str))
missing = [col for col in requested if col not in self.columns]
if missing:
raise Exception(
'Cannot drop non-existent column(s) %s; available columns: %s' % (', '.join(missing), ', '.join(self.columns))
)
Comment on lines +194 to +196

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Polars' missing-column exception type

For a strict drop of a missing literal column, this now raises a generic Exception before Polars can raise its documented ColumnNotFoundError. Any caller that catches the Polars exception to distinguish a missing column from unrelated failures will no longer handle this case, despite the change being intended to improve only the error message. Raise pl.exceptions.ColumnNotFoundError with the enhanced text instead.

Useful? React with 👍 / 👎.

meta = self.get_meta()
df = super().drop(*columns, strict=strict)
for col in list(meta.units.keys()):
Expand Down
Loading
Loading