feat(settings): confirm before deleting downloaded models - #3
Merged
Conversation
Model deletion previously fired immediately on click, risking accidental loss of 600-700 MB models that must be re-downloaded. Gate deletion behind the existing ConfirmationModal in all three model managers (Whisper, Parakeet, Summary/BuiltIn). - Add pendingDelete + isDeleting state; confirmDelete() wraps the existing deleteModel(), so delete logic and backend/API are unchanged. - Delete actions now open a confirmation dialog naming the model and freed size; buttons disable and show a Deleting... state during the async op. - Preserve e.stopPropagation() so opening the dialog never selects the card. No backend changes. tsc --noEmit clean; 63/63 Bun tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deleting a downloaded model previously happened immediately on click, with no
confirmation. Since transcription/summary models are large (~600–700 MB) and must be
re-downloaded if removed by mistake, an accidental click was costly.
This PR gates model deletion behind the existing
ConfirmationModalacross all threemodel managers — Whisper, Parakeet, and Summary (built-in AI) — without
changing any deletion logic or backend behaviour.
Addresses the confirmation gap called out in upstream [FEATURE] Delete downloaded
models in Settings (Zackriya-Solutions/meetily#597). The delete capability itself was
already implemented in Briefli; this adds the missing safety confirmation.
Why
ConfirmationModal, so it's consistent and low-risk.What changed
Per manager (
WhisperModelManager.tsx,ParakeetModelManager.tsx,BuiltInModelManager.tsx):pendingDelete+isDeletinglocal state.confirmDelete()that wraps the existingdeleteModel()— delete logic,toasts, list refresh, and the Rust commands are all unchanged.
Deletebutton on corruptedmodels) now open a confirmation dialog that names the model and the space it frees.
(
isConfirming).e.stopPropagation()so opening the dialog never selects/activates the model card.No backend/Rust changes. No new dependencies.
Before / After
Note: images to be attached in the GitHub UI — see PR comment.
Testing
tsc --noEmit -p tsconfig.json→ clean (exit 0).tests/lib) → 63/63 pass.Deletealso routes through the dialog.Scope / non-goals
delete_model(already correct)."Deleting…" state covers it.
trash icon for the currently-selected model (left as a separate follow-up).