Support RISC-V#60
Merged
Merged
Conversation
Signed-off-by: Antony Chazapis <chazapis@ics.forth.gr>
Member
|
We don't currently cross-build any of our architectures so this would be new. You've confirmed that the resulting artifacts function properly on a risc-v host? |
Contributor
Author
Sure. I have built k3s-root and k3s manually and tested them on a RISC-V QEMU VM running Ubuntu. This is some output to verify that the binaries are indeed usable: root@ubuntu:~# uname -a
Linux ubuntu 5.19.0-1012-generic #13~22.04.1-Ubuntu SMP Thu Jan 12 15:34:31 UTC 2023 riscv64 riscv64 riscv64 GNU/Linux
root@ubuntu:~# cd /var/lib/rancher/k3s/data/current/bin
root@ubuntu:/var/lib/rancher/k3s/data/current/bin# file busybox
busybox: ELF 64-bit LSB executable, UCB RISC-V, double-float ABI, version 1 (SYSV), statically linked, stripped
root@ubuntu:/var/lib/rancher/k3s/data/current/bin# ./busybox id
uid=0(root) gid=0(root) groups=0(root) |
Contributor
Author
|
I have also submitted a relevant PR in k3s. |
brandond
approved these changes
Jun 14, 2023
dereknola
approved these changes
Jun 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildroot already supports RISC-V, so it seems trivial to add this architecture to the list and move a step closer to RISC-V support for K3S.
I have already tested this manually, by running the
scripts/ciscript inside an Ubuntu 22.04 container with all necessary development tools. I also include the additional architecture in the Drone file.