ci(dco): exclude the Copilot coding agent from the DCO check - #462
Open
kke wants to merge 1 commit into
Open
Conversation
Commits pushed by the Copilot coding agent are authored by copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> and committed by GitHub, so they carry no Signed-off-by trailer and fail the DCO check exactly the way dependabot's commits would. dco-check compiles DCO_CHECK_EXCLUDE_PATTERN into a single regex and searches it against the commit author email, so both bot identities have to share one alternation rather than being listed separately. Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
There was a problem hiding this comment.
🟢 Approval recommended
The regex correctly excludes both supported bot identities without affecting other authors.
Pull request overview
Updates DCO validation to exempt commits authored by the Copilot coding agent.
Changes:
- Extends the bot email exclusion regex to include Copilot.
- Documents why bot-authored commits lack sign-offs.
File summaries
| File | Description |
|---|---|
.github/workflows/dco.yaml |
Adds the Copilot bot identity to DCO exclusions. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
IIRC the DCO check is a CNCF requirement. Worth checking if there's any guidance about DCO and machine-aurhored commits. |
Contributor
Author
|
Yep, this is a requirement to apply the copilot review suggestions and any possible copilot authored agentic workflow actions. @jnummelin any ideas? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits pushed by the Copilot coding agent are authored by copilot-swe-agent[bot] 198982749+Copilot@users.noreply.github.com and committed by GitHub, so they carry no Signed-off-by trailer and fail the DCO check exactly the way dependabot's commits would.
dco-check compiles DCO_CHECK_EXCLUDE_PATTERN into a single regex and searches it against the commit author email, so both bot identities have to share one alternation rather than being listed separately.