Repository navigation
Use JuliaFunctional/CompositionsBase.jl? #139
Description
I created https://github.com/JuliaFunctional/CompositionsBase.jl so that packages dealing with morphisms can share symbols like ⨟, compose, and opcompose (an ASCII alias of ⨟). As we discussed in JuliaFolds/Transducers.jl#67, my motivation is to use this from Transducers.jl. Do you want to use it from Setfield?
I also invited you to the organization so that you can tweak CompositionsBase.jl directly if you need to. Do you want to co-maintain it?
Activity
jw3126 commentedon May 30, 2020
Thanks for the invite, I am happy to co-maintain it. What do you mean by
As I understand, the operations in
CompositionBase.jlare all derived from∘? So they automatically work on lenses without any extra code needed in Setfield.jl?tkf commentedon May 30, 2020
Ah, I forgot that Setfield.jl didn't export
compose.So, you are right, there is no need for Setfield.jl to import CompositionsBase.jl (unless you want to re-export
composeetc.)jw3126 commentedon May 30, 2020
There is one subtle point.
Setfield.compose()is a lense, whileCompositionBase.compose()throws an error. Its a bit awkward. We could renameSetfield.composeinto e.g.lenscomposeand reexportCompositionBaseif you like.tkf commentedon May 30, 2020
Ah, good point. Well, if nobody asked to export this function, I think it's OK to keep it like this. Though probably a super careful approach is to use
lenscomposeso that it is possible to re-exportCompositionsBase.composefrom the top-level namespace at some point.